Date: Mon, 10 Apr 2017 18:35:24 +0300
From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GCC 7 warnings
Message-ID: <20170410153524.GA13447@e733.localdomain>
References: <dd7e5c64-86ec-9e96-e682-a57d1cb9bcc2@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd"
Content-Disposition: inline
In-Reply-To: <dd7e5c64-86ec-9e96-e682-a57d1cb9bcc2@2ndquadrant.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--ZPt4rx8FFjLCG7dd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Peter,

> c) Expand the target buffer sizes until the warning goes away.  (Sample
> patch attached.)

I personally think it's a great patch. Unfortunately I don't have GCC
7.0 right now but at least it doesn't break anything on 6.3.1. Since
there is no rush I would suggest to add an entry to the next commitfest,
so this patch wouldn't accidentally be lost.

As a side node I believe it would be great to replace all sprintf calls
to snprintf just to be on a safe side. IIRC we did something similar to
str* procedures not a long time ago. Unless there are any objections
regarding this idea I'm willing to write such a patch.

--=20
Best regards,
Aleksander Alekseev

--ZPt4rx8FFjLCG7dd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEECAokn0QZCoIHW4GpEEnCBLXCDtYFAljrpjkACgkQEEnCBLXC
DtYVlg/8DainwyCBVEpm7VyRbbCOLq2FadAItErTlxaY3KozkYMBX4wQR+Oy+rfV
na2slwi18Q9pF+aoVqpmwbEkj/gWjHhI1HoChZFv9sMXDE5Qn/6gxwpjFcIA3W+M
ewfM09kshmqp2G5vtQObceZgp0u6EsyrAi47QeMDVzDcRPMqj8vRyndG+52erA2q
ebVodXK8x5hDRCWhPtY/SSBrjeH67q2NjZAKWbX7py9qhVy0Z03VmGawZEorV2ZK
FHnFCm8eWtGRjaQfEygz018tM6paoaJwRr8qLDL8KqzaQlf/BYecxo45lxtC7Dnr
VwBAgirkhsJtwZR38i2pnpHA2ILJcPP+dLamUiJPaKXsLMGos3+7G1ZKH3xm0MMK
L+hmraJx3jAf0huXVhxNjBYTXS4+xmo55WMETMM7TKY4FOUq/efi7ZMFjn0j6Cy5
rsVMZNfuJZI0KdndnhFjnBGRB6EbFXrf2YVnjpf+6Q/rE3EqqVIg0Yniwp+WBFPb
sBHJYbL4TiDDfdO4HQve+mGP3Iq8B7EarEG+JXTRtZUtTrioQzKDOKCgDQhRx5dM
hVHlsKvl+WJI3hKXhZirD5hNv0PWGLNTelRdytDtA5+2FLhkpsoVe9Y8jHVR+KQI
vWaViRWghDeYMniokcvcs0FbDwE4tF/divalm/00RXucD1Ho2Bo=
=0wka
-----END PGP SIGNATURE-----

--ZPt4rx8FFjLCG7dd--