Date: Fri, 14 Apr 2017 05:56:44 +0000
From: Noah Misch <noah@leadboat.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Vitaly Burovoy <vitaly.burovoy@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: identity columns
Message-ID: <20170414055644.GF2870454@tornado.leadboat.com>
References: <c05eefac-0b55-74df-6343-71d232c15bc5@2ndquadrant.com>
 <CAKOSWNmRm0ydv1Yp8OzZ_GPh6Kfyhk+o-fxRb6onGfp433afFA@mail.gmail.com>
 <06a416db-e35b-36d1-7e2f-0affdee24745@2ndquadrant.com>
 <CAKOSWN=U0wfqjPuUbSEMAn_dcP7QnD_U0KskYf7OVhkVqs8CXA@mail.gmail.com>
 <4b1d703f-818f-00bf-4169-3279af377f3d@2ndquadrant.com>
 <CAKOSWNnxgYCVoNbmr2reMvwzQzyzgXMZn8F5JQhvkdFs73ae2g@mail.gmail.com>
 <59d8e32a-14de-6f45-c2b0-bb52e4a7522d@2ndquadrant.com>
 <CAKOSWNnLfPJE4b0_onw42QD64AzC7UESHDqK8sP2PAYERktOXQ@mail.gmail.com>
 <21ab7425-ae33-b0af-4177-f2ba88acd93a@2ndquadrant.com>
 <CAKOSWN=hUQWwyCJS8a3gTTUkvMkeg2iwSCCs=df0OYxJ_6H0kA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAKOSWN=hUQWwyCJS8a3gTTUkvMkeg2iwSCCs=df0OYxJ_6H0kA@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On Thu, Apr 06, 2017 at 10:26:16PM -0700, Vitaly Burovoy wrote:
> On 4/6/17, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
> > On 4/4/17 22:53, Vitaly Burovoy wrote:
> >> The next nitpickings to the last patch. I try to get places with
> >> lacking of variables' initialization.
> >> All other things seem good for me now. I'll continue to review the
> >> patch while you're fixing the current notes.
> >
> > Committed with your changes (see below) as well as executor fix.
> 
> Thank you very much!
> 
> 
> > As I tried to mention earlier, it is very difficult to implement the IF
> > NOT EXISTS behavior here, because we need to run the commands the create
> > the sequence before we know whether we will need it.
> 
> In fact with the function "get_attidentity" it is not so hard. Please,
> find the patch attached.
> I've implement SET GENERATED ... IF NOT EXISTS. It must be placed
> before other SET options but fortunately it conforms with the
> standard.
> Since that form always changes the sequence behind the column, I
> decided to explicitly write "[NO] CACHE" in pg_dump.
> 
> As a plus now it is possible to rename the sequence behind the column
> by specifying SEQUENCE NAME in SET GENERATED.
> 
> I hope it is still possible to get rid of the "ADD GENERATED" syntax.

[Action required within three days.  This is a generic notification.]

The above-described topic is currently a PostgreSQL 10 open item.  Peter,
since you committed the patch believed to have created it, you own this open
item.  If some other commit is more relevant or if this does not belong as a
v10 open item, please let us know.  Otherwise, please observe the policy on
open item ownership[1] and send a status update within three calendar days of
this message.  Include a date for your subsequent status update.  Testers may
discover new open items at any time, and I want to plan to get them all fixed
well in advance of shipping v10.  Consequently, I will appreciate your efforts
toward speedy resolution.  Thanks.

[1] https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers