Date: Fri, 14 Apr 2017 07:03:09 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>, Noah Misch <noah@leadboat.com>,
	PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test
Message-ID: <20170414110309.GV9812@tamriel.snowman.net>
References: 
 <CAMsr+YGn5tu+rhvC7hBgn2zmc7Y0egrQ79J6DUKsaeFLWdqrGQ@mail.gmail.com>
 <20170403151237.GK9812@tamriel.snowman.net>
 <CAB7nPqQKUoV6Vce4Ba9OTf8KA7n96rPM_EOD665hGHmaGFerDg@mail.gmail.com>
 <CAOuzzgoTyw+tW063W4A_UAj9SAqtHBTqgU_cE-4eGSS7V7kK_g@mail.gmail.com>
 <CAB7nPqS2Xj8Zs48mk7NjtKQa69Of3wtGJ+tKpgs2A-Ne9Zy4ww@mail.gmail.com>
 <20170404123011.GX9812@tamriel.snowman.net>
 <CAB7nPqToUk6z=+jk11rNiEShoL5963Jwx4jg+svKuKHvZ3hhtQ@mail.gmail.com>
 <20170405132426.GW9812@tamriel.snowman.net>
 <CAB7nPqTEV-N_nxE3UyP5bMNz1gd0om2zCTyut+Ohc4+dwRESgA@mail.gmail.com>
 <CAB7nPqTxoNiC62NSTwjk6nb62wf0C20x1QtBnpGdHNn6r=3dZw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jCWkHzhWrg6TRiVy"
Content-Disposition: inline
In-Reply-To: 
 <CAB7nPqTxoNiC62NSTwjk6nb62wf0C20x1QtBnpGdHNn6r=3dZw@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--jCWkHzhWrg6TRiVy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Michael,

* Michael Paquier (michael.paquier@gmail.com) wrote:
> On Thu, Apr 6, 2017 at 7:48 AM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
> > On Wed, Apr 5, 2017 at 10:24 PM, Stephen Frost <sfrost@snowman.net> wro=
te:
> >> * Michael Paquier (michael.paquier@gmail.com) wrote:
> >>> 1) Initialize the old cluster and start it.
> >>> 2) create a bunch of databases with full range of ascii characters.
> >>> 3) Run regression tests.
> >>> 4) Take dump on old cluster.
> >>> 4) Stop the old cluster.
> >>> 5) Initialize the new cluster.
> >>> 6) Run pg_upgrade.
> >>> 7) Start new cluster.
> >>> 8) Take dump from it.
> >>> 9) Run deletion script (Oops forgot this part!)
> >>
> >> Presumably the check to match the old dump against the new one is also
> >> performed?
> >
> > Yes. That's run with command_ok() at the end.
>=20
> Attached is an updated patch to use --no-sync with pg_dumpall calls.

Some of those were specifically left around to test those code paths.
I'm not sure if these were those or not though, Andrew was the one who
reviewed the various pg_dumpall calls to add --no-sync in places.

Thanks!

Stephen

--jCWkHzhWrg6TRiVy
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJY8KxtAAoJEO1sijiDR2RVptQP/2V4wR3vl7BwQV4UY6anAq22
fs5M0Wv4R4Kq+Vsm3Pzl113b5du7Dxjf6Ezwq1Bwcl0r2hyuWdR7GaPp5PwchC87
70PRWzfQ+rTX7venhIJdRyhNGNzd9TW5XWOCr6MokYAthL4c9Fc0wZKzUglbGrK/
0rinrMsxN/Pgb1Cb9QFUvegJXlLWzV7ooG9C3MCJno4NlGb4wu954gsojU+amTXO
6n53Ym5pm4GEMzZPwBbDlEjtXtM01ix9hPDsnEYdFbsLfb0NM5YflzBblBO7IZwC
1K/BL/tE1KdSgFET4ftE2x4l3Cr/4qRz41byaiyZ8aVdGRwX85QiU6TJFxko7jQF
I4l//9Ck5NoDi0okXp/GXtteOa31DcDtb6+wTGKnx/u/GOxE8Jtn/N4OasQrg99x
HXfKNYRHE7cEnA5MvgZvtduBFdZ9Ia2hSihdqOlJ3bXf0wtXSz4HY5OfDTPZCdAA
VKPhxdfPfjDjbV20yLHi/INL1eerpXwuCXMKHpfw6/++e2OCxUaWL9ObRdYDouBD
IMlNFqvUPCkQSWBezUGkUSFw+Z5FUGKYTUQFyl4B3IvQPfPzydDTKbCPinIs75Tj
TtzdqaKvIyJ4zH08I2rrEUlfQdrToVlI4VDzsPrWvnUFKq2kVv+9ovNwY4NgmfN2
6+Q9prxe1j2EXKfrL6zz
=DFM0
-----END PGP SIGNATURE-----

--jCWkHzhWrg6TRiVy--