Date: Fri, 14 Apr 2017 08:24:18 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>, Noah Misch <noah@leadboat.com>,
	PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test
Message-ID: <20170414122418.GC9812@tamriel.snowman.net>
References: 
 <CAB7nPqQKUoV6Vce4Ba9OTf8KA7n96rPM_EOD665hGHmaGFerDg@mail.gmail.com>
 <CAOuzzgoTyw+tW063W4A_UAj9SAqtHBTqgU_cE-4eGSS7V7kK_g@mail.gmail.com>
 <CAB7nPqS2Xj8Zs48mk7NjtKQa69Of3wtGJ+tKpgs2A-Ne9Zy4ww@mail.gmail.com>
 <20170404123011.GX9812@tamriel.snowman.net>
 <CAB7nPqToUk6z=+jk11rNiEShoL5963Jwx4jg+svKuKHvZ3hhtQ@mail.gmail.com>
 <20170405132426.GW9812@tamriel.snowman.net>
 <CAB7nPqTEV-N_nxE3UyP5bMNz1gd0om2zCTyut+Ohc4+dwRESgA@mail.gmail.com>
 <CAB7nPqTxoNiC62NSTwjk6nb62wf0C20x1QtBnpGdHNn6r=3dZw@mail.gmail.com>
 <20170414110309.GV9812@tamriel.snowman.net>
 <CAB7nPqRZXui-Z6zaFiSc0HxSwev7Rhi=P4R-_qm_0fUvNy+emQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="O0k5SZMpWIputb2o"
Content-Disposition: inline
In-Reply-To: 
 <CAB7nPqRZXui-Z6zaFiSc0HxSwev7Rhi=P4R-_qm_0fUvNy+emQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--O0k5SZMpWIputb2o
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Michael Paquier (michael.paquier@gmail.com) wrote:
> On Fri, Apr 14, 2017 at 8:03 PM, Stephen Frost <sfrost@snowman.net> wrote:
> > Some of those were specifically left around to test those code paths.
> > I'm not sure if these were those or not though, Andrew was the one who
> > reviewed the various pg_dumpall calls to add --no-sync in places.
>=20
> Well, Andrew has pushed the patch I have written, and the calls of
> pg_dumpall in pg_upgrade use --no-sync. The ones intentionally left
> are in src/bin/pg_dump/t/002_pg_dump.pl.

Ok. :)

Thanks!

Stephen

--O0k5SZMpWIputb2o
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJY8L9xAAoJEO1sijiDR2RVNtYP/2/TinXxDI0Z+wP94vH0JBuI
CTp9OnBtY56SCLeLobuQXB5eONTJ9jZRWKajT0bweGD3s/R8nZ0MeJ6RTPfxtXyP
ydNChGnBGcYIvPwK003UKSJ3MVClvDs18Bt011ie8b3BBnwdUN6gZj0Q2iUPd0Lr
ZfDL5e65SEVh764uuETlOpfteg7l/7oaRx7TVktpJj25IgYSaP8zWT0wJgyRJUgF
BaIbRrU/A85+TilduAXEPgu9izYwplC16QTlRePQw2Utm18Lm9grLSquxA9tUi6E
p2zd/FKocm5c/KYUzuz32L4GA54TE1ILMNr6yM3b3GFj/caZy4QJSOXOHSUohIVD
dgDtol6BGKEKIH0wPhHwzAtIsA8u8FZn430dov1E5TvVxCEchTXL82a5nKOPWsuj
Hp079xCyw3vUhrfvg+xkHUBzyQHonsJ5Q+evzTVlz+EPLgDgWxUjeuL5cIebj95s
si3lWXlFwZ8CDyYfRcul5QEaoRh3UrDVoDRQ0ottTcAaVncK9GADSaXLJVGI5SvL
DA49Ef+UPUXoKlHcafcm/EYZHHjEw2UX4H2gSL1iN02TMoxBuL937pyjpZ8KQnEK
/iDh+7KfKDlZphVAq1nwOgG2xeX3hkjl2BjUv3eNyWqCihqHuN7n2wUVQJs31t2Q
GxpEFYWJCl6y9I/naSI9
=92RR
-----END PGP SIGNATURE-----

--O0k5SZMpWIputb2o--