Date: Thu, 4 May 2017 00:19:04 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
	Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Noah Misch <noah@leadboat.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Message-ID: <20170504041904.GD21223@tamriel.snowman.net>
References: <20170420234334.GW9812@tamriel.snowman.net>
 <9b7baae3-21b5-a730-1ec4-aee290d54518@lab.ntt.co.jp>
 <20170425154247.GJ9812@tamriel.snowman.net>
 <5cdfd834-695a-9c05-8fb4-cde08de21a9b@lab.ntt.co.jp>
 <20170426143157.GA21223@tamriel.snowman.net>
 <47e1d272-8ce0-dea8-2bb5-642efa95c337@lab.ntt.co.jp>
 <20170427141726.GF21223@tamriel.snowman.net>
 <696c2d04-80aa-57e2-c1c5-6df25e2bbed5@lab.ntt.co.jp>
 <20170503030520.GR21223@tamriel.snowman.net>
 <CA+HiwqFn=iGV_sg53CtX+kqmNGm7vdT7sbgzTNOfJ5w=O4H5zg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="zN1HJFR/B7wwTray"
Content-Disposition: inline
In-Reply-To: 
 <CA+HiwqFn=iGV_sg53CtX+kqmNGm7vdT7sbgzTNOfJ5w=O4H5zg@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--zN1HJFR/B7wwTray
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Amit,

* Amit Langote (amitlangote09@gmail.com) wrote:
> On Wed, May 3, 2017 at 12:05 PM, Stephen Frost <sfrost@snowman.net> wrote:
> > * Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> >> Attached updated patches.
> >
> > Please find an updated version which corrects the issue with
> > binary-upgrade of partitioned tables having partitions in other schemas,
> > along with a few other minor improvements.
> >
> > If you could take a look at it, I'd appreciate it.  We already had a
> > test case in the pg_dump TAP tests for partitions existing in a schema
> > different from the partitioned table, but we weren't checking the
> > binary-upgrade case, so I've added a check to do that now.  I'm sure
> > additional tests would be good to add and will take a look at doing that
> > tomorrow, but this hopefully closes at least the latest issue.
> >
> > Assuming this looks good to you, I'll push it tomorrow, possibly with
> > other minor adjustments and perhaps a few more tests.
>=20
> Your latest patch looks good to me.

Ok, great, thanks for taking a look at it.  Too late for me to push it
tonight, so I'll do so tomorrow.

Thanks again!

Stephen

--zN1HJFR/B7wwTray
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJZCqu4AAoJEO1sijiDR2RVHB0P/1y0l56ow/6og1I9ozLMyzIU
Ke0PLvLZrs0cOwjcpEi/MC+6pjfDzCUU3qJZOvnYmwcGTtsMU5RJ4bbVgeZ8yH3n
V6m5TD3nh/IbLexfP+Tw9XrYQjVg6joGMsIFdi3O9RGI1OOUEHV7jxUR5sJU8W80
9PSZ77a5peEgZZtOBZh/9Q3xOLC44xEmqkMYAgsQaq2uJGhl0drinQPlb9JoIghQ
HwgKRpCwwACyPdJrgS4OzMp+gzINQSHrZDDIE34X54jZJ0py4Y1rQr6NGpiy/k3R
1sjAPesC+WZD24u44EZHfsHJZOCxsSCVsGGmumXJM7O9RhUH09xBGBK7N+y1eKBx
zxTqQjTP3Ya8TqID8T3AFSVLArnU1rk6Bj82V1i1JGKeeL2yJW0CM+uxEQPfD7iJ
JdaDMt56FIlVTBvWpQSFrLMyoPaVU7ImmBCyAd25O+ScueHL82dd8rHIf+LGRHF3
mUV9XDoFBHS5E7u7hk9ePmeApvmJ70o4994W3sazScFMT1IlUIIRhr29aLeEPyxc
y8CCpOeP0/lHBLat0sk6gsaKxKe+S1PtR1kygfwVlHq83XaCE8H+77M8fP62yu72
cKSfYxECV6DErRXRjMLwzNjj0d0/xCF1bqkU0PK6NLz2jNry4euiu1/FnkXJKXcr
nBj1eq2eSFT+py6XXk4K
=HjiI
-----END PGP SIGNATURE-----

--zN1HJFR/B7wwTray--