Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9sIk-00078v-EA for pgsql-hackers@arkaria.postgresql.org; Sun, 14 May 2017 12:07:06 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d9sIk-0005R1-13 for pgsql-hackers@arkaria.postgresql.org; Sun, 14 May 2017 12:07:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d9sHD-0002mT-Be for pgsql-hackers@postgresql.org; Sun, 14 May 2017 12:05:31 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9sHA-0001tS-Nm for pgsql-hackers@postgresql.org; Sun, 14 May 2017 12:05:30 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 4949D21C070E for ; Sun, 14 May 2017 15:05:27 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru Received: from localhost.localdomain (broadband-46-242-9-54.moscow.rt.ru [46.242.9.54]) by mail.postgrespro.ru (Postfix) with ESMTPA id 007E921C034E for ; Sun, 14 May 2017 15:05:26 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1494763527; bh=46MBneQ1JxgR0qr34yf6wALP2QdDoSIgYd36BPrCtwI=; h=Date:From:To:Subject; b=NrISrF7UATmTjf+CV5Oyvi+r84M4blGQ1/vXgdZjch4bRnC4oMQ/mxrbUuYAWGrpS RwptOcePtXDw/Rm8Ud80cotPZ8+LpnfstrYFkCrc4vt9u79sPiF3F6gUov2D0e58tv oNSgvAp2kStNoHrkUYMwGK5XgddwXSl+rxX0McKU= Date: Sun, 14 May 2017 15:05:25 +0300 From: Ildus Kurbangaliev To: PostgreSQL Hackers Subject: Bug in ExecModifyTable function and trigger issues for foreign tables Message-ID: <20170514150525.0346ba72@postgrespro.ru> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/iH10F977daJoNCRD4A1iphz" X-Pg-Spam-Score: -2.0 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org --MP_/iH10F977daJoNCRD4A1iphz Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hello hackers, i was experimenting with fdw tables recently, and discovered two bugs in postgres core code (tested on stable 9.6 and master). Steps to reproduce: 1) create parent table 2) create child local table 3) create child foreign table 4) create 'before row update` trigger at foreign table 5) make update query on parent table. I attached sql file with these steps. At the end postgres will show an error like: ERROR: could not open file "base/12410/33037": No such file or directory 33037 is relid of the foreign table. Bug is related with the fact that postgres will try use latest scanned tupleid from local table to try get an old tuple for trigger of foreign table. It should be fixed with the patch like: --- a/src/backend/executor/nodeModifyTable.c +++ b/src/backend/executor/nodeModifyTable.c @@ -1324,7 +1324,6 @@ ExecModifyTable(ModifyTableState *node) JunkFilter *junkfilter; TupleTableSlot *slot; TupleTableSlot *planSlot; - ItemPointer tupleid = NULL; ItemPointerData tuple_ctid; HeapTupleData oldtupdata; HeapTuple oldtuple; @@ -1381,6 +1380,8 @@ ExecModifyTable(ModifyTableState *node) */ for (;;) { + ItemPointer tupleid = NULL; + After this patch the second bug will appear: TRAP: FailedAssertion("!(((const void*)(fdw_trigtuple) != ((void *)0)) ^ ((bool) (((const void*)(tupleid) != ((void *)0)) && ((tupleid)->ip_posid != 0))))", File: "trigger.c", Line: 2428) I'm not sure how it should be fixed, because as I see `oldtuple` will be set only for AFTER ROW triggers by `wholerow` junk attribute. Regards, Ildus Kurbangaliev --MP_/iH10F977daJoNCRD4A1iphz Content-Type: application/sql Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=test.sql LyogOiVzL3VzZXIxL3lvdXJfdXNlcm5hbWUvZyAqLwovKiBjb25uZWN0IHRv IGZvcmVpZ24gc2VydmVyICovClxjIHBvc3RncmVzIHVzZXIxIGxvY2FsaG9z dCA1NDMzCgpjcmVhdGUgdGFibGUgZnRhYmxlKHZhbCBpbnQpOwppbnNlcnQg aW50byBmdGFibGUgc2VsZWN0IGkgZnJvbSBnZW5lcmF0ZV9zZXJpZXMoMjAs IDI1KSBpOwoKLyogY29ubmVjdCB0byBiYXNlIHNlcnZlciAqLwpcYyBwb3N0 Z3JlcyB1c2VyMSBsb2NhbGhvc3QgNTQzMgoKY3JlYXRlIGV4dGVuc2lvbiBw b3N0Z3Jlc19mZHc7CgpjcmVhdGUgdGFibGUgcGFyZW50KHZhbCBpbnQpOwpj cmVhdGUgdGFibGUgY2hpbGQxKCkgaW5oZXJpdHMgKHBhcmVudCk7CgppbnNl cnQgaW50byBwYXJlbnQgc2VsZWN0IGkgZnJvbSBnZW5lcmF0ZV9zZXJpZXMo MCwgMTApIGk7Cmluc2VydCBpbnRvIGNoaWxkMSBzZWxlY3QgaSBmcm9tIGdl bmVyYXRlX3NlcmllcygxMCwgMjApIGk7CgovKiBzaG91bGQgYmUgYWxsIG9r ICovCnVwZGF0ZSBwYXJlbnQgc2V0IHZhbCA9IHZhbCArIDE7CgovKiBub3cg d2UgYWRkIGZkdyB0YWJsZSAqLwpjcmVhdGUgc2VydmVyIGZzZXJ2Cglmb3Jl aWduIGRhdGEgd3JhcHBlciBwb3N0Z3Jlc19mZHcKCW9wdGlvbnMgKGRibmFt ZSAncG9zdGdyZXMnLCBob3N0ICcxMjcuMC4wLjEnLCBwb3J0ICc1NDMzJyk7 CmNyZWF0ZSB1c2VyIG1hcHBpbmcgZm9yIHVzZXIxIHNlcnZlciBmc2VydiBv cHRpb25zICh1c2VyICd1c2VyMScpOwppbXBvcnQgZm9yZWlnbiBzY2hlbWEg cHVibGljIGxpbWl0IHRvIChmdGFibGUpIGZyb20gc2VydmVyIGZzZXJ2IGlu dG8gcHVibGljOwphbHRlciB0YWJsZSBmdGFibGUgaW5oZXJpdCBwYXJlbnQ7 CgovKiBzaG91bGQgYmUgYWxsIG9rICovCnVwZGF0ZSBwYXJlbnQgc2V0IHZh bCA9IHZhbCArIDE7CgovKiBjcmVhdGUgYmVmb3JlIHJvdyB0cmlnZ2VyIG9u IGZkdyB0YWJsZSAqLwpjcmVhdGUgb3IgcmVwbGFjZSBmdW5jdGlvbiBkb19u b3RoaW5nKCkgcmV0dXJucyB0cmlnZ2VyIGFzICQkCmJlZ2luCglyZXR1cm4g bmV3OwplbmQKJCQgbGFuZ3VhZ2UgcGxwZ3NxbDsKCmNyZWF0ZSB0cmlnZ2Vy IG9uX3VwZGF0ZQoJYmVmb3JlIHVwZGF0ZSBvbiBmdGFibGUKCWZvciBlYWNo IHJvdyBleGVjdXRlIHByb2NlZHVyZSBkb19ub3RoaW5nKCk7CgovKiB3aWxs IGZhaWwgKi8KdXBkYXRlIHBhcmVudCBzZXQgdmFsID0gdmFsICsgMTsK --MP_/iH10F977daJoNCRD4A1iphz Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --MP_/iH10F977daJoNCRD4A1iphz--