Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dACAZ-0006sl-Bh for pgsql-hackers@arkaria.postgresql.org; Mon, 15 May 2017 09:19:59 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dACAY-0002LD-Ur for pgsql-hackers@arkaria.postgresql.org; Mon, 15 May 2017 09:19:58 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dAC93-00081M-IO for pgsql-hackers@postgresql.org; Mon, 15 May 2017 09:18:25 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAC8z-0000uu-Ts for pgsql-hackers@postgresql.org; Mon, 15 May 2017 09:18:24 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id C5DC021C05E4; Mon, 15 May 2017 12:18:18 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru Date: Mon, 15 May 2017 12:16:38 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1494839898; bh=vq+qqieXe+Qd5PHdOTG0t2lWd+e+OWhzNjuPVOjjU/A=; h=From:To:Cc:Subject:In-Reply-To:References; b=efEEwRWoLx5lm4ogS7G2bDzKC49omLicwE0ZDy/v69SvJVkt2P+icUhZEd1WEfQHL hRiASwFw5D2C6Hj2WbHe+iPAPb2ZzUEXjeNlZH9GmLTvZHYzg/IwztlWlk7CdahRl9 z9MYnjtd3k/YRMNIMtartL8b31CAiepWcB76oCKY= From: Ildus Kurbangaliev To: Dilip Kumar Cc: PostgreSQL Hackers Subject: Re: Bug in ExecModifyTable function and trigger issues for foreign tables Message-ID: <20170515121638.0c076bcc@wp.localdomain> In-Reply-To: References: <20170514150525.0346ba72@postgrespro.ru> Organization: Postgres Professional X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.0 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On Mon, 15 May 2017 10:34:58 +0530 Dilip Kumar wrote: > On Sun, May 14, 2017 at 9:54 PM, Dilip Kumar > wrote: > > After your fix, now tupleid is invalid which is expected, but seems > > like we need to do something more. As per the comments seems like it > > is expected to get the oldtuple from planSlot. But I don't see any > > code for handling that part. > > Maybe we should do something like attached patch. > Hi, planSlot contains already projected tuple, you can't use it as oldtuple. I think problem is that `rewriteTargetListUD` called only for parent relation, so there is no `wholerow` attribute for foreign tables. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers