Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAGUL-00005t-IB for pgsql-hackers@arkaria.postgresql.org; Mon, 15 May 2017 13:56:41 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dAGUL-00073a-2E for pgsql-hackers@arkaria.postgresql.org; Mon, 15 May 2017 13:56:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dAGUK-000739-6m for pgsql-hackers@postgresql.org; Mon, 15 May 2017 13:56:40 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dAGUG-0005uB-Ii for pgsql-hackers@postgresql.org; Mon, 15 May 2017 13:56:39 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 1D49021C05F4; Mon, 15 May 2017 16:56:35 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru Date: Mon, 15 May 2017 16:54:55 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1494856594; bh=/7ODDb0mnA8RSH9zT507NKOtzqjQEIed2tBOUTpA4eU=; h=From:To:Cc:Subject:In-Reply-To:References; b=Upr/eldKe1vVZ2fiqnKo+ppELpuXemfeaqlz2K2ijbnJRKAYkUxyWnwvxlrNsREtx sGi/ygXXXkDBwrVcqeh4ELctuewe4LMl6bNT++jp5Bl1JvmwCIfaVKQacBLpiplwSf /uSOimN+UScNgasWgbRetZLr3zgr6/dWCGNN9mys= From: Ildus Kurbangaliev To: Ashutosh Bapat Cc: Dilip Kumar , PostgreSQL Hackers Subject: Re: Bug in ExecModifyTable function and trigger issues for foreign tables Message-ID: <20170515165455.545dd3d6@wp.localdomain> In-Reply-To: References: <20170514150525.0346ba72@postgrespro.ru> <20170515121638.0c076bcc@wp.localdomain> Organization: Postgres Professional X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.0 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On Mon, 15 May 2017 17:43:52 +0530 Ashutosh Bapat wrote: > On Mon, May 15, 2017 at 2:46 PM, Ildus Kurbangaliev > wrote: > > On Mon, 15 May 2017 10:34:58 +0530 > > Dilip Kumar wrote: > > > >> On Sun, May 14, 2017 at 9:54 PM, Dilip Kumar > >> wrote: > >> > After your fix, now tupleid is invalid which is expected, but > >> > seems like we need to do something more. As per the comments > >> > seems like it is expected to get the oldtuple from planSlot. > >> > But I don't see any code for handling that part. > >> > >> Maybe we should do something like attached patch. > >> > > > > Hi, > > planSlot contains already projected tuple, you can't use it as > > oldtuple. I think problem is that `rewriteTargetListUD` called only > > for parent relation, so there is no `wholerow` attribute for > > foreign tables. > > Yes. postgresAddForeignUpdateTargets() which is called by > rewriteTargetListUD injects "ctid". "wholerow" is always there. Not > for postgres_fdw but for other wrappers it might be a bad news. ctid, > whole row obtained from the remote postgres server will fit the tuple > descriptor of parent, but for other FDWs the column injected by > rewriteTargetListUD() may make the child tuple look different from > that of the parent, so we may not pass that column down to the child. > I'm trying to say that when we have a regular table as parent, and foreign table as child, in rewriteTargetListUD `wholerow` won't be added, because rewriteTargetListUD will be called only for parent relation. You can see that by running the script i provided in the first message of this thread. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers