Date: Tue, 30 May 2017 02:24:06 +0000
From: Noah Misch <noah@leadboat.com>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>,
	Andres Freund <andres@anarazel.de>,
	David Steele <david@pgmasters.net>,
	Michael Paquier <michael.paquier@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Aleksander Alekseev <a.alekseev@postgrespro.ru>,
	PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: recursive json_populate_record()
Message-ID: <20170530022406.GD116176@gust.leadboat.com>
References: <16179.1485380983@sss.pgh.pa.us>
 <CAB7nPqSGyCxh9CqPXp5TTE+A0svyWvbO1sp3BT87VtDxtT4tLQ@mail.gmail.com>
 <9bf14a7c-0794-f90c-c012-8dd0335ab364@pgmasters.net>
 <bcb6edee-f124-d5f4-3314-09b5274bd328@pgmasters.net>
 <754780af-d905-9704-cf4d-b64e632b86a3@2ndQuadrant.com>
 <20170403211741.7ommm5dssfv3abo6@alap3.anarazel.de>
 <45c0aa55-1b62-c622-31fd-cb21e017d5cd@2ndQuadrant.com>
 <8fcd9e65-acb0-8221-ef23-01e5c2fe90e4@2ndQuadrant.com>
 <ad7bc08c-b5af-e4e7-cc61-0ea326f5aa42@2ndQuadrant.com>
 <fbd1d566-bba0-a3de-d6d0-d3b1d7c24ff2@postgrespro.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fbd1d566-bba0-a3de-d6d0-d3b1d7c24ff2@postgrespro.ru>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On Mon, May 22, 2017 at 10:19:37PM +0300, Nikita Glukhov wrote:
> Attached two small fixes for the previous committed patch:
> 
> 1. I've noticed a difference in behavior between json_populate_record()
> and  jsonb_populate_record() if we are trying to populate record from a
> non-JSON-object: json function throws an error but jsonb function returns
> a record with NULL fields. So I think it would be better to throw an error
> in jsonb case too, but I'm not sure.
> 
> 2. Also I've found a some kind of thinko in JsGetObjectSize() macro, but it
> seems that this obvious mistake can not lead to incorrect behavior.

[Action required within three days.  This is a generic notification.]

The above-described topic is currently a PostgreSQL 10 open item.  Andrew,
since you committed the patch believed to have created it, you own this open
item.  If some other commit is more relevant or if this does not belong as a
v10 open item, please let us know.  Otherwise, please observe the policy on
open item ownership[1] and send a status update within three calendar days of
this message.  Include a date for your subsequent status update.  Testers may
discover new open items at any time, and I want to plan to get them all fixed
well in advance of shipping v10.  Consequently, I will appreciate your efforts
toward speedy resolution.  Thanks.

[1] https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers