Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWuVY-0002ue-LB for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jul 2017 01:07:32 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dWuVX-0001xT-5c for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Jul 2017 01:07:31 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dWuVW-0001xK-FH for pgsql-hackers@postgresql.org; Mon, 17 Jul 2017 01:07:30 +0000 Received: from mail-pg0-x229.google.com ([2607:f8b0:400e:c05::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dWuVS-0006P0-Qp for pgsql-hackers@postgresql.org; Mon, 17 Jul 2017 01:07:28 +0000 Received: by mail-pg0-x229.google.com with SMTP id u5so8541947pgq.3 for ; Sun, 16 Jul 2017 18:07:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=32nFOlTkDj+Jy3iYon4YWEJ1B/xMOEJ7U62nDjcyj3g=; b=UsB9BPzx5TRuFLxDI3Bva2oc0/7uV0G1eH1b8N7HkPZtMSb3pQwxRFKBo14wYTGoML viMlOrbcbddAolVs0xEoQUVXdT6JfkCbYIJIUj9Ou0MgFYQPTUyS8VeqAO/GIH6HrL4V KCzhHLRI7X0PZar5TNrpjlNnlnMuhAFIfneHY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=32nFOlTkDj+Jy3iYon4YWEJ1B/xMOEJ7U62nDjcyj3g=; b=eOZ1/jAxh2EZslbo6aCc2bnVXmJE78ow/rRlVc1+GNmrPZqV99wOaZb97Qw3SELZNo Dxc2r+ZScE1n1mvO2HoGDDZcaehCcEEGYurUCnvN/+6H3Rg3wygUCeTsBoQ+mCua2a+0 fcVfe5aiX2kc/QPXoTxnbaZVu5KVv67POyzJRfAHRscjcix9hgWWrd9Qk9I8J2BQBllU Wq8GFNtWbbjn+9iTQqd9C5bRB3PsdJK+WLhNb49MsWNAtDbNH7J9Y+JEeDSUzq72aUz2 rzzqqwMAMZGDK/zV76JpS5fVVcS7kgaMkDPavXCEyud18vJo2mQDsDCvAxwPv4kny3AM zc0g== X-Gm-Message-State: AIVw1114Bw/+svJQT/5cNos8D1oeTFN+dMsPPRH80a2cKOHaniL9iudA DhKYpynJ9cr0OZJu X-Received: by 10.99.123.28 with SMTP id w28mr26581622pgc.183.1500253645493; Sun, 16 Jul 2017 18:07:25 -0700 (PDT) Received: from rfd.leadboat.com (c-73-158-248-138.hsd1.ca.comcast.net. [73.158.248.138]) by smtp.gmail.com with ESMTPSA id v128sm2171850pgv.49.2017.07.16.18.07.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Jul 2017 18:07:24 -0700 (PDT) Date: Mon, 17 Jul 2017 01:07:21 +0000 From: Noah Misch To: Andres Freund Cc: Julien Rouhaud , pgsql-hackers , Tom Lane Subject: Re: segfault in HEAD when too many nested functions call Message-ID: <20170717010721.GD2170455@rfd.leadboat.com> References: <12302.1500132157@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12302.1500132157@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On Sat, Jul 15, 2017 at 11:22:37AM -0400, Tom Lane wrote: > Julien Rouhaud writes: > > Since b8d7f053c5c2bf2a7e8734fe3327f6a8bc711755 (Andres in Cc), if you > > write queries which result in infinite recursion (or just too many > > nested function calls), execution ends with segfault instead of intended > > exhausted max_stack_depth: > > Yes. We discussed this before the patch went in [1]. I wanted to put > a stack depth check in ExecProcNode(), and still do. Andres demurred, > claiming that that was too much overhead, but didn't really provide a > credible alternative. The thread drifted off without any resolution, > but clearly we need to do something before 10.0 final. [Action required within three days. This is a generic notification.] The above-described topic is currently a PostgreSQL 10 open item. Andres, since you committed the patch believed to have created it, you own this open item. If some other commit is more relevant or if this does not belong as a v10 open item, please let us know. Otherwise, please observe the policy on open item ownership[1] and send a status update within three calendar days of this message. Include a date for your subsequent status update. Testers may discover new open items at any time, and I want to plan to get them all fixed well in advance of shipping v10. Consequently, I will appreciate your efforts toward speedy resolution. Thanks. [1] https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers