Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M334220=pgsql-hackers-arkari@postgresql.org>)
	id 1dnFdk-0005Ev-2n
	for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Aug 2017 02:55:32 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M334220=pgsql-hackers-arkari@postgresql.org>)
	id 1dnFdi-00071z-Vd
	for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Aug 2017 02:55:31 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <noah@leadboat.com>)
	id 1dnFcA-0004Ff-EV
	for pgsql-hackers@postgresql.org; Thu, 31 Aug 2017 02:53:54 +0000
Received: from mail-pg0-x235.google.com ([2607:f8b0:400e:c05::235])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.84_2)
	(envelope-from <noah@leadboat.com>)
	id 1dnFc7-00027l-7X
	for pgsql-hackers@postgresql.org; Thu, 31 Aug 2017 02:53:52 +0000
Received: by mail-pg0-x235.google.com with SMTP id t193so8261844pgc.1
        for <pgsql-hackers@postgresql.org>;
 Wed, 30 Aug 2017 19:53:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=leadboat.com; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=GOnqkeahmIF6HFqMGgwP5/31WpaKSpUt/3glD8n53gE=;
        b=dzmH24X17MIVdfthmPaChZPcGRWW1lWNNcqO1W/aZ4P4iqMU00WpPtT26rP6I5j530
         iq8y29gSbfVkFbl7z/Cmsk7bddBZeEDCqdBBuDlpNWTnX5cFTNWwKCFWC5PlQpoL9+yZ
         flAnPWFDsfsAZmAdc/qr1XBk/xlKe2o/Ygb8w=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=GOnqkeahmIF6HFqMGgwP5/31WpaKSpUt/3glD8n53gE=;
        b=OabEHnZYXpYrV2Qwpjw1V1BiENP/rV/9l4zgX52X5enD4PFFyxJS2y1ahjYem3BnmK
         ne3xzvIR3BI/lPg7oqelhtf1epddLTCVNR4t8hCJ5uX7B+EtwC0ARdBWgVuEDR2pLXl4
         IbArS3PuxZ/AS1WrKWaLHgoLahHyZ39kZDsRJVCGc9xuqgylUx/5ZLc2fJ/DzaXZ6t4s
         qfFwXGcWtF0SwEdtDt0kDYH8/T1cotdbS7m+KfZZwytxR0r3WshbfbaoI1PJ/MW1JEw0
         vzcnr41qx/zZsFjNsyLciNS3afbAIFxiDcyRoVNQuywgpGVixBPkTggh3n+TRmS4O4bE
         95cw==
X-Gm-Message-State: AHYfb5glyTjajxlbvSiibbOc9VL/nQo0nIsy96lMBWNNsPgXRnXp2ZSQ
	jt7q2hJxko//MhhKRgW+6A==
X-Received: by 10.84.131.71 with SMTP id 65mr916514pld.134.1504148029674;
        Wed, 30 Aug 2017 19:53:49 -0700 (PDT)
Received: from rfd.leadboat.com (c-73-158-248-138.hsd1.ca.comcast.net.
 [73.158.248.138])
        by smtp.gmail.com with ESMTPSA id
 b5sm11797875pfc.36.2017.08.30.19.53.47
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Wed, 30 Aug 2017 19:53:48 -0700 (PDT)
Date: Thu, 31 Aug 2017 02:53:45 +0000
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: Back-branch release notes up for review
Message-ID: <20170831025345.GE3963697@rfd.leadboat.com>
References: <7025.1503775872@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7025.1503775872@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On Sat, Aug 26, 2017 at 03:31:12PM -0400, Tom Lane wrote:
> +    <listitem>
> +<!--
> +Author: Peter Eisentraut <peter_e@gmx.net>
> +Branch: master [0659465ca] 2017-08-15 19:27:22 -0400
> +Branch: REL_10_STABLE [3ea58216d] 2017-08-15 19:30:35 -0400
> +Branch: REL9_6_STABLE [dce90c7c8] 2017-08-15 19:31:06 -0400
> +Branch: REL9_5_STABLE [dbeefe64f] 2017-08-15 19:32:00 -0400
> +Branch: REL9_4_STABLE [52427015a] 2017-08-15 19:32:41 -0400
> +Branch: REL9_3_STABLE [9f0f4efc2] 2017-08-15 19:32:52 -0400
> +Branch: REL9_2_STABLE [98e6784aa] 2017-08-15 19:33:04 -0400
> +-->
> +     <para>
> +      Show foreign tables
> +      in <structname>information_schema</>.<structname>table_privileges</>
> +      view (Peter Eisentraut)
> +     </para>
> +
> +     <para>
> +      All other relevant <structname>information_schema</> views include
> +      foreign tables, but this one ignored them.
> +     </para>
> +
> +     <para>
> +      Since this view definition is installed by <application>initdb</>,
> +      merely upgrading will not fix the problem.  If you need to fix this
> +      in an existing installation, you can, as a superuser, do this
> +      in <application>psql</>:
> +<programlisting>
> +BEGIN;
> +DROP SCHEMA information_schema CASCADE;
> +\i <replaceable>SHAREDIR</>/information_schema.sql
> +COMMIT;
> +</programlisting>
> +      (Run <literal>pg_config --sharedir</> if you're uncertain
> +      where <replaceable>SHAREDIR</> is.)  This must be repeated in each
> +      database to be fixed.
> +     </para>
> +    </listitem>

"DROP SCHEMA information_schema CASCADE;" will drop objects outside
information_schema that depend on objects inside information_schema.  For
example, this will drop user-defined views if the view query refers to
information_schema.  That's improper in a release-noted update procedure.
This could instead offer a CREATE OR REPLACE VIEW or just hand-wave about the
repaired definition being available in information_schema.sql.

I regret not reading this before today.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers