Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drn53-0004zP-9I for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Sep 2017 15:26:29 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1drn52-0000s7-T3 for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Sep 2017 15:26:28 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1drn51-0000r7-PJ for pgsql-hackers@postgresql.org; Tue, 12 Sep 2017 15:26:27 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drn4x-0004Dl-H6 for pgsql-hackers@postgresql.org; Tue, 12 Sep 2017 15:26:26 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 9424021C1D2D; Tue, 12 Sep 2017 18:26:22 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru Received: from wp.localdomain (unknown [192.168.27.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 5E31921C1D2C; Tue, 12 Sep 2017 18:26:22 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1505229982; bh=e8CFahoIdxqMVS0vnCbUCfY5vH9KKNEtFPHDPQSVSc8=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=eov+7dC4z8sA9uZs1FqS+w27tk8aGsk22dtj+2ChwmBjYj/xOnYnqHu7yUC2CTbnM LV/NCn9qtSVzngAuppXf9rZPHcC9L6Zcb84GTOmfgt+r+V9CcyCqS5FP5BoUlz5i9K yHNOtC27ZhURgiRXpw7HuqKQSJP3NzqCn/SZ4N+8= Date: Tue, 12 Sep 2017 18:26:22 +0300 From: Ildus Kurbangaliev To: Etsuro Fujita Cc: Tom Lane , Ashutosh Bapat , Dilip Kumar , PostgreSQL Hackers , Robert Haas Subject: Re: Bug in ExecModifyTable function and trigger issues for foreign tables Message-ID: <20170912182622.608b47c4@wp.localdomain> In-Reply-To: References: <20170514150525.0346ba72@postgrespro.ru> <20170516150516.1b616230@wp.localdomain> <20170615180548.5e142ddc@wp.localdomain> <0bc9c28b-96ca-c875-871e-16af6f53ecd9@lab.ntt.co.jp> <428f1672-df54-de01-91da-b57365193bf4@lab.ntt.co.jp> <6c651916-8fde-f9c9-b199-080df1bf2867@lab.ntt.co.jp> <280720c5-7aad-1136-6be3-654208c8f714@lab.ntt.co.jp> <8065.1500475011@sss.pgh.pa.us> <9cd25d80-08fc-568c-3181-dbe98723d0db@lab.ntt.co.jp> <3e9ff40d-d00f-3363-dcee-97ce023c7884@lab.ntt.co.jp> Organization: Postgres Professional X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On Mon, 24 Jul 2017 11:59:13 +0900 Etsuro Fujita wrote: > On 2017/07/21 19:16, Etsuro Fujita wrote: > > On 2017/07/20 11:21, Etsuro Fujita wrote: > >> On 2017/07/19 23:36, Tom Lane wrote: > >>> Please put the responsibility of doing const-expression > >>> simplification in these cases somewhere closer to where the > >>> problem is being created. > >> > >> It would be reasonable that it's the FDW's responsibility to do > >> that const-simplification if necessary? > > There seems to be no objections, so I removed the const-expression > > simplification from the patch and I added the note to the docs for > > AddForeignUpdateTargets. > > > > Attached is an updated version of the patch. > > I cleaned up the patch a bit. PFA a new version of the patch. > > Best regards, > Etsuro Fujita Checked, looks good to me. Changed status to 'Ready for Commiter'. -- --- Ildus Kurbangaliev Postgres Professional: http://www.postgrespro.com Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers