Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duE6X-0001iP-IL for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Sep 2017 08:42:05 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1duE6X-00015D-3T for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Sep 2017 08:42:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1duE6V-00014G-TP for pgsql-hackers@postgresql.org; Tue, 19 Sep 2017 08:42:03 +0000 Received: from smtprelay0245.b.hostedemail.com ([64.98.42.245] helo=smtprelay.b.hostedemail.com) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1duE6N-000680-Pa for pgsql-hackers@postgresql.org; Tue, 19 Sep 2017 08:42:03 +0000 Received: from filter.hostedemail.com (10.5.19.248.rfc1918.com [10.5.19.248]) by smtprelay01.b.hostedemail.com (Postfix) with ESMTP id 94D472D2A21; Tue, 19 Sep 2017 08:41:53 +0000 (UTC) X-Session-Marker: 616C76686572726540616C76682E6E6F2D69702E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,alvherre@alvh.no-ip.org,:::,RULES_HIT:41:355:379:599:967:973:988:989:1260:1277:1311:1312:1313:1314:1345:1359:1437:1515:1516:1518:1519:1534:1539:1593:1594:1595:1596:1711:1714:1730:1747:1777:1792:2194:2199:2393:2525:2560:2563:2682:2685:2693:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3351:3865:3866:3867:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4605:5007:6261:8957:9010:9025:9108:9121:10004:10400:10848:11232:11658:11914:12438:12679:13069:13311:13357:13439:13894:13895:14721:14764:21080:21324:21433:21627:30006:30036:30054,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: join75_4aae51cf2c73e X-Filterd-Recvd-Size: 1497 Received: from alvin.alvh.no-ip.org (p579F8EE0.dip0.t-ipconnect.de [87.159.142.224]) (Authenticated sender: alvherre@alvh.no-ip.org) by omf13.b.hostedemail.com (Postfix) with ESMTPA; Tue, 19 Sep 2017 08:41:53 +0000 (UTC) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id A116BD67; Tue, 19 Sep 2017 10:41:51 +0200 (CEST) Date: Tue, 19 Sep 2017 10:41:51 +0200 From: Alvaro Herrera To: Tom Lane Cc: pgsql-hackers@postgreSQL.org Subject: Re: Pre-existing bug in trigger.c Message-ID: <20170919084151.slpsbmero7lzth5u@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1976.1505599106@sss.pgh.pa.us> User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Tom Lane wrote: > After studying this awhile, I've concluded that neither of those > ideas leads to a fix simple enough that I'd be comfortable with > back-patching it. What seems like the best answer is to not pass > delete_ok = true to afterTriggerInvokeEvents in AfterTriggerEndQuery. > Then, afterTriggerInvokeEvents will examine the passed event list > pointer only during its loop initialization, at which time it's > surely still valid. For reference: this fix was committed as 27c6619e9c8f. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers