Date: Thu, 19 Oct 2017 14:20:52 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Nikolay Shaplov <dhyan@nataraj.su>
Cc: Michael Paquier <michael.paquier@gmail.com>,
	PostgreSQL mailing lists <pgsql-hackers@postgresql.org>,
	Andres Freund <andres@anarazel.de>
Subject: Re: [PATCH] Tests for reloptions
Message-ID: <20171019122052.f3cychhfktrfwqdk@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1933219.021c0Pr2Ov@x200m>
User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0)
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Nikolay Shaplov wrote:
> В письме от 3 октября 2017 11:48:43 пользователь Michael Paquier написал:

> I've been thinking a lot, and rereading the patch. When I reread it I've been 
> thinking that I would like to add more tests to it now... ;-)
> 
> If the only purpose of tests is to get better coverage, then I would agree 
> with you. But I've been thinking that tests also should check that everything 
> behaves as expected (or as written in documentation).
> 
> I would say that options names is a of part of SQL dialect that postgres uses, 
> kind of part of the syntax. It is good to be sure that they still supported. 
> So I would add a test for every option heap supports.

Yeah, it would perhaps be good idea to ensure we don't break things that
are documented to work.  If the tests don't take too long, I'm not
opposed to testing every single option.  As you say, code coverage is
important but it's not the only goal.

I'm hesitant to hardcode things like the number of bits in bloom, as you
had in the original.  If I understand correctly, that number could
change with compile options (different blocksize?), so I removed that
part.  I also fixed a few spelling errors.

And pushed.  Let's see what the buildfarm says about this.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers