Date: Tue, 14 Nov 2017 11:42:46 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
	Haribabu Kommi <kommi.haribabu@gmail.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	Thomas Munro <thomas.munro@enterprisedb.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Pluggable storage
Message-ID: <20171114104246.aijbulukit2pt6zj@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+TgmobOyL+qBARGd1R=3u3dVgLtr1B1MZHJBOkuRoH1e_JLnw@mail.gmail.com>
User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0)
Precedence: bulk

Hmm.  Am I reading it right that this discussion led to moving
essentially all code from tqual.c to heapam?  Given the hard time we've
had to get tqual.c right, it seems fundamentally misguided to me to
require that every single storage AM reimplements all the visibility
routines.

I think that changing tqual's API (such as not passing HeapTuples
anymore but some other more general representation) would be okay and
should be sufficient, but this wholesale movement of code seems
dangerous and wasteful in terms of future reimplementations that will be
necessary.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services