Date: Tue, 28 Nov 2017 17:57:00 +0300
From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Cc: Victor Drobny <v.drobny@postgrespro.ru>
Subject: Re: new function for tsquery creartion
Message-ID: <20171128145659.GA32487@e733.localdomain>
References: <fe931111ff7e9ad79196486ada79e268@postgrespro.ru>
 <15517a04afd2be779e2e6d69611c348b@postgrespro.ru>
 <20171128143916.1377.5847.pgcf@coridan.postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga"
Content-Disposition: inline
In-Reply-To: <20171128143916.1377.5847.pgcf@coridan.postgresql.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
Precedence: bulk


--opJtzjQTFsWo+cga
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Victor,

> I like the idea and I think it's a great patch. However in current shape =
it
> requires some amount of reworking to meet PostgreSQL standards of code qu=
ality.

Also I would like to add that I agree with Thomas Munro:

> Calling this search syntax just "query" seems too general and
> overloaded.  "Simple search", "simple query", "web search", "web
> syntax", "web query", "Google-style query", "Poogle" (kidding!) ...
> well I'm not sure, but I feel like it deserves a proper name.
> websearch_to_tsquery()?

websearch_to_tsquery() sounds much better than query_to_tsquery().

Also I agree Tomas Vondra in regard that:

> 2) I don't think we should mention Google in the docs explicitly. Not
> that I'm somehow anti-google, but this syntax was certainly not invented
> by Google - I vividly remember using something like that on Altavista
> (yeah, I'm old). And it's used by pretty much every other web search
> engine out there ...

I suggest to rephrase:

```
+    about its input. <function>queryto_tsquery</function> provides a=20
+    different, Google like syntax to create tsquery.
```

=2E. to something more like "provides a different syntax, similar to one
used in web search engines, to create tsqeury". And maybe give a few
examples right in the next sentence.

--=20
Best regards,
Aleksander Alekseev

--opJtzjQTFsWo+cga
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEECAokn0QZCoIHW4GpEEnCBLXCDtYFAlodeTkACgkQEEnCBLXC
DtZeVA/+MpxIL8csIpFjBXBIppfNwCFlVhQcjjSeN24DtjMY3kJdZN72Q5LLd++O
d9PGSIBzRKM/Gsa38TRkFVMAUT/MC3g7Es8UsaOx+38aSXsrLpvQWpNd+ST/NOJa
8e8kVaPW4c3217lH0dnGnYC2xqaEF5R8QgvWRjNlb8m1FLMjFkFFu1SO+9hAVVGB
iKsDhJFBEZ5v8fmnDOu2vMkvfUMcMfyhVKP2PeWSxcfUqQzw4++daEcrEgaAb9RH
LmzW6RjPEFnMn+n4evcXllQQReQbUwhLAEJKuuA+lsYqzjQVhA9oqaFLpCXKXqNO
NEowOJ3dJqwNThL2GttX2wXQ612Xjz6QF+AoH3X5zQRvhmUzRW1Ci89XGjJ0Rizb
5YJb/4wizvNhN66FQBw95G66+xKnztcrR89zhtZkgcugd/IqzDLAvT0tUkeknNoR
+PpqDg5KxPLtNH3mgTXsPkphksYxswHyX74wETZinmQ2nq8BNrNvWKaJPtnH0+//
bVFhhQi2WN96LVGH9FC+3jgcm3pX6D85lgEFYdntW/uyAqFBoo4JN4N3IuzTJxYB
uz+v0BKyYTKJWEiSCdDSDl+d8BY3Yc//p7qKSaa4QyutBk1hg340NXjRj+6Qz59b
vzfOjdYZkjkQVhPLeVZwHo07uGDWKpb0t079vdTmwHkq/U9yjto=
=K0OA
-----END PGP SIGNATURE-----

--opJtzjQTFsWo+cga--