Date: Tue, 28 Nov 2017 14:41:50 -0800
From: Andres Freund <andres@anarazel.de>
To: =?utf-8?B?0K7RgNC40Lkg0KHQvtC60L7Qu9C+0LI=?= <funny.falcon@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Tom Lane <tgl@sss.pgh.pa.us>,
	Claudio Freire <klaussfreire@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Sokolov Yura <funny.falcon@postgrespro.ru>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	PostgreSQL-Dev <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Small improvement to compactify_tuples
Message-ID: <20171128224150.syswowiaiojth7ke@alap3.anarazel.de>
References: <20171107152004.axgznk3n5tkzvnnt@alap3.anarazel.de>
 <29007.1510090796@sss.pgh.pa.us>
 <CA+TgmobyDksaVkoj=VTFovcw02mMBrjsbx7F9Nvm4tXTHU6HfQ@mail.gmail.com>
 <19570.1510155199@sss.pgh.pa.us>
 <CAGTBQpZgs4hVmDtHg4F6MDJuAE9-U=z6d+yJzjPsZup7AZhV0Q@mail.gmail.com>
 <22996.1510160560@sss.pgh.pa.us>
 <CAL-rCA3n4Neat4pH382nuZ9v0-SCZOBJ=KHT5CoBGXim=KTAhw@mail.gmail.com>
 <CAL-rCA2cCyvapkb15fADR3qKsRMo+XimPgmGviur1ui-y0q-aQ@mail.gmail.com>
 <CAH2-WznEQBxeij1_PnczUD=vQqS0aPWOxJAkmjH_rXoBpeo0ZQ@mail.gmail.com>
 <CAL-rCA3=MiVU7SWenhPL0a3e5KfOkzvXZDp_WL+ea2Ky57Fqdg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAL-rCA3=MiVU7SWenhPL0a3e5KfOkzvXZDp_WL+ea2Ky57Fqdg@mail.gmail.com>
Precedence: bulk

Hi,

On 2017-11-28 23:30:53 +0300, Юрий Соколов wrote:
> index 1a8ee08c8b..607ed6a781 100644
> --- a/src/port/qsort.c
> +++ b/src/port/qsort.c
> @@ -8,7 +8,7 @@
>   *	  in favor of a simple check for presorted input.
>   *	  Take care to recurse on the smaller partition, to bound stack usage.
>   *
> - *	CAUTION: if you change this file, see also qsort_arg.c, gen_qsort_tuple.pl
> + *	CAUTION: if you change this file, see also qsort_arg.c, qsort_template.h
>   *
>   *	src/port/qsort.c
>   */

Maybe it's a stupid question. But would we still want to have this after
the change? These should be just specializations of the template version
imo.

Greetings,

Andres Freund