Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJshG-0001Be-9F for pgsql-hackers@arkaria.postgresql.org; Wed, 29 Nov 2017 03:06:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJshF-0000Dc-Rz for pgsql-hackers@arkaria.postgresql.org; Wed, 29 Nov 2017 03:06:01 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eJshF-0000DR-Hy for pgsql-hackers@lists.postgresql.org; Wed, 29 Nov 2017 03:06:01 +0000 Received: from smtprelay0133.b.hostedemail.com ([64.98.42.133] helo=smtprelay.b.hostedemail.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eJshA-0006fz-Cl for pgsql-hackers@postgresql.org; Wed, 29 Nov 2017 03:06:00 +0000 Received: from filter.hostedemail.com (10.5.19.248.rfc1918.com [10.5.19.248]) by smtprelay06.b.hostedemail.com (Postfix) with ESMTP id D58628D017; Wed, 29 Nov 2017 03:05:54 +0000 (UTC) X-Session-Marker: 616C76686572726540616C76682E6E6F2D69702E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,alvherre@alvh.no-ip.org,:::,RULES_HIT:41:355:379:599:967:973:988:989:1260:1277:1311:1312:1313:1314:1345:1359:1437:1515:1516:1518:1519:1534:1540:1593:1594:1595:1596:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2898:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3865:3866:3867:3868:3870:3871:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4605:5007:6261:7875:8957:9025:9121:10004:10400:10848:11232:11658:11914:12438:12663:12740:12895:13069:13311:13357:13439:13894:13895:14764:21080:21627:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: sheep73_6dc879a4fcd06 X-Filterd-Recvd-Size: 1671 Received: from alvin.alvh.no-ip.org (pc-233-81-161-190.cm.vtr.net [190.161.81.233]) (Authenticated sender: alvherre@alvh.no-ip.org) by omf12.b.hostedemail.com (Postfix) with ESMTPA; Wed, 29 Nov 2017 03:05:54 +0000 (UTC) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 774C09F8; Wed, 29 Nov 2017 00:05:50 -0300 (-03) Date: Wed, 29 Nov 2017 00:05:50 -0300 From: Alvaro Herrera To: Justin Pryzby Cc: pgsql-hackers@postgresql.org Subject: Re: PG10.1 autovac killed building extended stats Message-ID: <20171129030550.d3pe2cmkblyj2zvx@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171127133338.GC19405@telsasoft.com> User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Justin Pryzby wrote: > On Fri, Nov 17, 2017 at 03:43:52PM -0600, Justin Pryzby wrote: > > On Fri, Nov 17, 2017 at 01:36:00PM -0300, Alvaro Herrera wrote: > > > If I recall things correctly, the "continue" should be executed > > > regardless of IsAutoVacuumWorkerProcess() (only the log should be > > > conditional on that). I'm not sure how I arrived at the current coding, > > > which I added in bf2a691e02d7 -- probably just fuzzy thinking. > > > > Is it useful to run with that change ? > > FYI: the affected server ran without crashing since Nov 18 with this change. Many thanks for patching and verifying that it works. I pushed the fix now. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services