Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKGf5-0001X3-UC for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Nov 2017 04:41:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eKGf5-00072Q-8a for pgsql-hackers@arkaria.postgresql.org; Thu, 30 Nov 2017 04:41:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eKGf5-00072G-2I for pgsql-hackers@lists.postgresql.org; Thu, 30 Nov 2017 04:41:23 +0000 Received: from mail-qk0-x22b.google.com ([2607:f8b0:400d:c09::22b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eKGey-0005O3-Od for pgsql-hackers@postgresql.org; Thu, 30 Nov 2017 04:41:22 +0000 Received: by mail-qk0-x22b.google.com with SMTP id r184so7350892qke.8 for ; Wed, 29 Nov 2017 20:41:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YoPd/an1O5QJOUm6+1QHF+5lQ/0XVdQp+qwXn5tHXkI=; b=L/4dnAKJ63QOcP5gcBcw4Q7yXiHT7nFlv//ooNYXBRB7ZzhMSNxEaloB/YynWC5GPV wB3nbnGlbWqzgB8+XWjySrAv/Qe0i7X78ZoQ65k3XuLtf1g8MExGSQAgUZTyF5EDr6ss w6vnC6vfAuvr/h7LC+zrQse6zESB24Za4aXoE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YoPd/an1O5QJOUm6+1QHF+5lQ/0XVdQp+qwXn5tHXkI=; b=JnyPb0WElmgbCrWFYqeaCfc4k8nDV4DGzsqXc4VRkrD6ZBbqT5wbj0CHHh8Fq4JJ8R 3EvBaW8xQbzZyW7J2q16fejCWZFI4bWiu7+fHXQS2yr73X2ppJIF0uBM5HVNjpF/7+O/ pJc0glINtuqL2sRrzH/p7Hl3FY6pLl17mp9m35teBcE0s7EzxS2+J0jyReYaOzrnQzCI hKAb2psgF7e4SRW44wdkFrJTvctQCOgDgydDhrSyHAc/H2kB4OdD1j8tY8kUN/Bf6gdV 0mXB7wnsfupQ6bS7PwJndkbkXfgl+xqZyecaPPAUmEV35yxG85wbBjwOhzMF/dXU6y0g KF9Q== X-Gm-Message-State: AKGB3mJA2fdMMwOMEfBEXgATsDU9N3HUqV0++SgW+Ylx2RP8qv4dRr8I Y0kvZGYqrhWqLNfDSbZmjX3wfA== X-Google-Smtp-Source: AGs4zMaFQQNxQgl3vKfSrsVThn1SmrFlYegj9NX+ms7Klb/8ytWO2QCJhVfcctdLRRsVXrEhLoyGJg== X-Received: by 10.55.21.39 with SMTP id f39mr1026221qkh.263.1512016875041; Wed, 29 Nov 2017 20:41:15 -0800 (PST) Received: from rfd.leadboat.com (c-73-158-248-138.hsd1.ca.comcast.net. [73.158.248.138]) by smtp.gmail.com with ESMTPSA id r22sm2402776qtc.71.2017.11.29.20.41.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Nov 2017 20:41:14 -0800 (PST) Date: Wed, 29 Nov 2017 20:41:11 -0800 From: Noah Misch To: Tom Lane Cc: Dave Page , Sandeep Thakkar , Ashutosh Sharma , Robert Haas , pgsql-hackers Subject: Re: pl/perl extension fails on Windows Message-ID: <20171130044111.GA3207353@rfd.leadboat.com> References: <1708!2.1502718166@sss.pgh.pa.us> <10406.1502743029@sss.pgh.pa.us> <1914.1502978317@sss.pgh.pa.us> <4515.1502981857@sss.pgh.pa.us> <17646.1502983856@sss.pgh.pa.us> <19438.1502986558@sss.pgh.pa.us> <20171130041441.GA3161526@rfd.leadboat.com> <84899.1512016496@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84899.1512016496@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Nov 29, 2017 at 11:34:56PM -0500, Tom Lane wrote: > Noah Misch writes: > > On Thu, Aug 17, 2017 at 12:15:58PM -0400, Tom Lane wrote: > >> ... it's now looking to me like we should do the above with X = 5.13.4. > >> That won't be a perfect solution, but it's about the best we can > >> readily do. Realistically, nobody out in the wider world is likely > >> to care about building current PG releases against such old Perl > >> versions on Windows; if we satisfy our older buildfarm critters, > >> it's enough for me. > > > MinGW default behavior matches "cl -D_USE_32BIT_TIME_T", and MSVC >= 2005 > > default behavior matches "gcc -D__MINGW_USE_VC2005_COMPAT"[1]. MinGW-built > > Perl[2] does not mention _USE_32BIT_TIME_T in $Config{ccflags}, so we > > typically must add _USE_32BIT_TIME_T when using MSVC to build 32-bit against > > MinGW-built Perl. I'm considering two ways to achieve this: > > I don't really have an opinion about the relative merits of these changes, > but why do anything? The existing solution has the buildfarm happy, and > we've not heard any field complaints that I saw. I'm not sure we should > spend more time on supporting obsolete toolchain combinations that aren't > represented in the buildfarm. It's the other way around. The buildfarm's 32-bit MSVC animals each use an obsolete Perl. PostgreSQL is incompatible with today's 32-bit ActivePerl and Strawberry Perl.