Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOIa9-000266-O0 for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Dec 2017 07:32:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eOIa9-0006nf-1f for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Dec 2017 07:32:57 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eOIa8-0006nU-7K for pgsql-hackers@lists.postgresql.org; Mon, 11 Dec 2017 07:32:56 +0000 Received: from mail-pf0-x22e.google.com ([2607:f8b0:400e:c00::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eOIa0-0005l0-OQ for pgsql-hackers@postgresql.org; Mon, 11 Dec 2017 07:32:54 +0000 Received: by mail-pf0-x22e.google.com with SMTP id j124so10932994pfc.2 for ; Sun, 10 Dec 2017 23:32:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=y2AA2sq75/pARpDJHXWjv4So31VgfIQWl6ByvzHBLCo=; b=TfSnmeZF87351dgCFGsN3U3gnli2u1dtHS10l8K7os46E79IaNEo3z8NsmSCVQTWXq qSevn6yOwwtDo2AzlQtZfpAuVO4aoT0dmmFzQXX0x2sW2AtNKolN2DsX43mbFRufrT0T rIthYJnUCS18ASIZRxXQlY/tDAtrHChVnCswo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=y2AA2sq75/pARpDJHXWjv4So31VgfIQWl6ByvzHBLCo=; b=LhwEO3RyXclYhYLbn9Geb2+D63WiXdJCJFhOssnryNcTWk6qSTQ3VAcs87aMmo/xxL 4sM3WH5bzjd0CeB+LKtFiy0nE5q9MynR3BnDlS7IdTLNhgslopseisI/mZeM4i3jsFwu 3+xtNQZwY4KDPVGc2OilXS5WEP/pWpxlsYCEK9rV11IfgHj8lTie0LaVn6BuwXWf7+Ay txgbEiHONgCJSVDSF+tjItRxumYRZ0HzDjQjRO9HvKJ3Hv6cknI11vYDLXE2EpBNrMao b0cTQwu7SMBRsCvoWjg25QACywReGD6jbtZCk63qQqC3ankwarFHtUT9l9CixL1lG+rq elJg== X-Gm-Message-State: AJaThX4QmGlknE6lGYSaDdQQ+2+tuTTsnKqjz3wZ3d7ZB8GsKuoXAqwK 3tDcnjnO+Dj8h7QiktMOOORgCg== X-Google-Smtp-Source: AGs4zMaIQSvsqjpI+UnYc/K+z3MBitzHwhL4oaoE4hY1HyQ3qdz+C2KyznybBgfiLU6vZnlwdJBNXA== X-Received: by 10.101.96.213 with SMTP id r21mr36344504pgv.395.1512977566719; Sun, 10 Dec 2017 23:32:46 -0800 (PST) Received: from rfd.leadboat.com (c-73-158-248-138.hsd1.ca.comcast.net. [73.158.248.138]) by smtp.gmail.com with ESMTPSA id d81sm24739846pfj.163.2017.12.10.23.32.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Dec 2017 23:32:45 -0800 (PST) Date: Sun, 10 Dec 2017 23:32:43 -0800 From: Noah Misch To: Michael Paquier Cc: PostgreSQL mailing lists Subject: Re: SIGPIPE in TAP tests Message-ID: <20171211073243.GA3624262@rfd.leadboat.com> References: <20171209210203.GC3362632@rfd.leadboat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Mon, Dec 11, 2017 at 04:19:52PM +0900, Michael Paquier wrote: > On Sun, Dec 10, 2017 at 6:02 AM, Noah Misch wrote: > If SIGPIPE is ignored then test output just stops after generating the > FATAL message. Oops. You mean "If SIGPIPE is not ignored ...", right? > > To fix the actual failures, we can cease sending "SELECT 1"; it's enough to > > disconnect immediately. Patch attached. > > Perhaps you could use an empty string instead? I feel a bit uneasy > about passing an undefined object to IPC::Run::run. IPC::Run documents the equivalence of undef and '' in this context; search for "close a child processes stdin" in http://search.cpan.org/~rbs/IPC-Run-0.78/lib/IPC/Run.pm. Thus, I expect both spellings to work reliably, and I find "undef" slightly more evocative.