Date: Sun, 17 Dec 2017 23:24:19 +0100
From: David Fetter <david@fetter.org>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgreSQL.org
Subject: Re: [HACKERS] Something for the TODO list: deprecating abstime and
 friends
Message-ID: <20171217222419.GA30764@fetter.org>
References: <30691.1500156034@sss.pgh.pa.us>
 <20171213080506.cwjkpcz3bkk6yz2u@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171213080506.cwjkpcz3bkk6yz2u@alap3.anarazel.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Wed, Dec 13, 2017 at 12:05:06AM -0800, Andres Freund wrote:
> On 2017-07-15 18:00:34 -0400, Tom Lane wrote:
> > * contrib/spi/timetravel depends on abstime columns to represent what
> > would nowadays be better done as a tstzrange.  I'd have thought we
> > could maybe toss that example module overboard, but we just today got
> > a question about its usage, so I'm afraid it's not quite dead yet.
> > What shall we do with that?
> 
> Looking at the code I'd be pretty strongly inclined to scrap it.
> 
> 
> Before I'd discovered this thread, I'd started to write up a
> patch. Attached. It's clearly not fully done. Questions I'd while
> hacking things up:
> - what to do with contrib/spi/timetravel - I'd just removed it from the
>   relevant Makefile for now.

Porting it to tstzrange seems friendlier, however:

- Does that look like significant work to do this port?
- How about the work involved with upgrading existing installations?

> - nabstime.c currently implements timeofday() which imo is a pretty
>   weird function. I'd be quite inclined to remove it at the same time as
>   this.

+1 for binning it.

Best,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate