Date: Thu, 4 Jan 2018 23:10:40 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: michael.paquier@gmail.com, thomas.munro@enterprisedb.com,
	tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, david@pgmasters.net,
	hlinnaka@iki.fi, simon@2ndquadrant.com, andres@anarazel.de,
	masao.fujii@gmail.com, kleptog@svana.org,
	pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] WAL logging problem in 9.4.3?
Message-ID: <20180105041040.GI2416@tamriel.snowman.net>
References: <20170913.174239.25978735.horiguchi.kyotaro@lab.ntt.co.jp>
 <20170914.153459.94374240.horiguchi.kyotaro@lab.ntt.co.jp>
 <CAB7nPqSqukqS5Xx6_6KEk53eRy5ObdvaNG-5aN_4cE8=gTeOdg@mail.gmail.com>
 <20171211.175424.09346818.horiguchi.kyotaro@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="K3awxsxIuSNw2oFG"
Content-Disposition: inline
In-Reply-To: <20171211.175424.09346818.horiguchi.kyotaro@lab.ntt.co.jp>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--K3awxsxIuSNw2oFG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Kyotaro HORIGUCHI (horiguchi.kyotaro@lab.ntt.co.jp) wrote:
> At Tue, 28 Nov 2017 10:36:39 +0900, Michael Paquier <michael.paquier@gmai=
l.com> wrote in <CAB7nPqSqukqS5Xx6_6KEk53eRy5ObdvaNG-5aN_4cE8=3DgTeOdg@mail=
=2Egmail.com>
> > On Thu, Sep 14, 2017 at 3:34 PM, Kyotaro HORIGUCHI
> > <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> > > At Wed, 13 Sep 2017 17:42:39 +0900 (Tokyo Standard Time), Kyotaro HOR=
IGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote in <20170913.174239.25978735=
=2Ehoriguchi.kyotaro@lab.ntt.co.jp>
> > >> filterdiff seems to did something wrong..
> > >
> > > # to did...
>=20
> It's horrid to see that:p
>=20
> > > The patch is broken by filterdiff so I send a new patch made
> > > directly by git format-patch. I confirmed that a build completes
> > > with applying this.
> >=20
> > To my surprise this patch still applies but fails recovery tests. I am
> > bumping it to next CF, for what will be its 8th registration as it is
> > for a bug fix, switching the status to "waiting on author".
>=20
> Thank you for checking that. I saw maybe the same failure. It
> occurred when visibilitymap_set() is called with heapBuf =3D
> InvalidBuffer during recovery. Checking pendingSyncs and
> no_pending_sync before the elog fixes it. Anyway the DEBUG2 elogs
> are to removed before committing. They are just to look how it
> works.
>=20
> The attached patch applies on the current HEAD and passes all
> recovery tests.

This is currently marked as 'waiting on author' in the CF app, but it
sounds like it should be 'Needs review'.  If that's the case, please
update the CF app accordingly.  If you run into any issues with that,
let me know.

Thanks!

Stephen

--K3awxsxIuSNw2oFG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJaTvrAAAoJEO1sijiDR2RVDDYQAIhIGNLRhFW2Czc+Ux3hz/37
DMFgu4ZH9pfO8ClbyKeglL2S7aMQ50Wzv+FKQHpd3IMJDuxWDzY0W2VzmiHp4Xw/
EqcZ4ErmhnPn7+T7WXgMs0g/K9N2iV5+TmLiObJYZauUiO57TIhB3vudPYQ08K+1
hqAUb7Ec8L3YTpiikCZUwzwQa0MnR9qdIgWzIBuh05lsTIwU+0HCPTyiwpL3LuvA
cWFDRb3HXqM9KjKnLRCP09q9XEKE3r4uMKIwRZtdLzNtEqetTvZ1wPXoYih7rG3c
BJXKdYR99Ao4u00/L41omMribch3rozq0nhOR9PrCKngffO78AP/a23angYYqROf
H/mCN00Z3P2E7Rpmfo+6Yy6wumxdP1i6PlhNbl1xihey6jb2uawQuPTgOXOw6MZN
x3VmWznq9vFPRVYLjq87AZ3Y8mPKMaJYaCrqDfhVH20tqBxjCE8i3Lh2MQwtFtfv
nl6NFN3ov1q4jNHyjfr2uSTRFRpbxFhEltrm45UnBBQ8lyuV/guE57m1ZAlkgiq8
kSI7UrPQdTznXRe27BFKPGCeptt8mbYnqtkFdemAb9F0PKm7C6Yomcf75p0rw17L
Qxqh7Fy9wWZ2iQcDzQeBc8z5V9ZTWR6WWehBH47XPV4AJ1YTZ0ov+d2XRy72bujV
rV8bGqAwtp+JHQJwDKng
=lNcJ
-----END PGP SIGNATURE-----

--K3awxsxIuSNw2oFG--