Date: Sat, 6 Jan 2018 16:49:25 -0500
From: Stephen Frost <sfrost@snowman.net>
To: "Rady, Doug" <radydoug@amazon.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: pgbench - option to build using ppoll() for larger
 connection counts
Message-ID: <20180106214925.GM2416@tamriel.snowman.net>
References: <3B729131-C891-41F3-B911-8DEB05515D63@amazon.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="VCtz4IOOco5WWJgr"
Content-Disposition: inline
In-Reply-To: <3B729131-C891-41F3-B911-8DEB05515D63@amazon.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--VCtz4IOOco5WWJgr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Doug,

* Rady, Doug (radydoug@amazon.com) wrote:
> This patch enables building pgbench to use ppoll() instead of select()
> to allow for more than (FD_SETSIZE - 10) connections.  As implemented,
> when using ppoll(), the only connection limitation is system resources.

Looks like this patch had some good feedback back when it was posted,
but we haven't seen any update to it based on that feedback and we're
now nearly a week into the January commitfest.

In order to keep the commitfest moving and to give you the best
opportunity at having the patch be reviewed and committed during this
cycle, I'd suggest trying to find some time soon to incorporate the
recommendations provided and post an updated patch for review.

Thanks!

Stephen

--VCtz4IOOco5WWJgr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJaUURlAAoJEO1sijiDR2RVGOcQALSShkFzXr8tOcIqG1/6yvnn
doDYkJTbm9mhVCnO6IU7u1YhjS+rvr7MnI8rN0ns7iToEYBSgHu3ZrRgw9URlzMZ
GL8omyieNqvq0OZk0Axffz5Xv1mG83C73EuviLkOD8h6Y8JOHSs5gPRr6L9CsODf
nOHbZPDOZDQOFkvW2Vxncg5+D3H1prk7SbqQ9AYnFtW0N+o1St64x/xb/kfP8Ljs
kMt5mi6c2L4X/ET9/4ymL9947wfnRHsAVvCoD9Dji9HxSWl5AxlmrqVGm4umlyEJ
tDX6ScnzJaNEmdhGUljyZgaRfM+o2ZJa9142o13KkfE/WE4+ZmK6IQu0kgjQ7X9G
1txN7DvPNF7GVhpt0J+kVX+qmvXNwGPSvHT10ZAf5/+RRTlQ5QbamokFleb0T1kq
n/hurHQntEoeTaDaNwV+P1OZ40TKalHoYW0Xu/UL09Xc9uHW/uO60xvvWyL5Xm18
R4hENLbjWMlwi695Gz3W2C24gU/Ea4GC6L8SvxN9YALbg3vOzT4uaArNz8v8xhei
gTjZFaWe4BaNDLEylNj2S5FvTedSDJyAmtlkSfmUzb6FM+YDR8/lmSm7B3/Pg8KO
JYITmAgCPNq4jbA/6EbbcCgbkHoycBYk+Lq6oG2M3tl+6eEOlkBMCQOnqKXh+im0
ZfNCnptkF7r/OJdvS4rY
=GWtX
-----END PGP SIGNATURE-----

--VCtz4IOOco5WWJgr--