Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXwhl-0003yI-9E for pgsql-hackers@arkaria.postgresql.org; Sat, 06 Jan 2018 22:12:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eXwhj-0005X8-Hw for pgsql-hackers@arkaria.postgresql.org; Sat, 06 Jan 2018 22:12:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eXwhj-0005Wy-BN for pgsql-hackers@lists.postgresql.org; Sat, 06 Jan 2018 22:12:39 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eXwhe-0003TS-PP for pgsql-hackers@postgresql.org; Sat, 06 Jan 2018 22:12:38 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id 53F435F79C; Sat, 6 Jan 2018 17:12:33 -0500 (EST) Date: Sat, 6 Jan 2018 17:12:33 -0500 From: Stephen Frost To: Fabien COELHO Cc: Ildar Musin , pgsql-hackers Subject: Re: General purpose hashing func in pgbench Message-ID: <20180106221233.GN2416@tamriel.snowman.net> References: <0e8bd39e-dfcd-2879-f88f-272799ad7ef2@postgrespro.ru> <699225ee-c30c-b22e-4028-415e9eab26b2@postgrespro.ru> <80e9c570-5c49-1a01-f309-3d8d0cbbae42@postgrespro.ru> <38f1503e-7b63-4612-24a9-041af25bb022@postgrespro.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p3vPLop7SaiM7XTa" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --p3vPLop7SaiM7XTa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings Ildar, * Fabien COELHO (coelho@cri.ensmp.fr) wrote: > >>I noticed from the source of all human knowledege (aka Wikipedia:-) > >>that there seems to be a murmur3 successor. Have you considered it? > >>One good reason to skip it would be that the implementation is long > >>and complex. I'm not sure about a 8-byte input simplified version. > >Murmur2 naturally supports 8-byte data. Murmur3 has 32- and 128-bit > >versions. >=20 > Ok. >=20 > So it would make sense to keep the 64 bit murmur2 version. >=20 > Pgbench ints are 64 bits, seems logical to keep them that way, so 32 bits > versions do not look too interesting. This sounds like it was settled and the patch needs updating with these changes, and with documentation and tests added. While the commitfest is still pretty early on, I would suggest trying to find time soon to update the patch and resubmit it, so it can get another review and hopefully be included during this commitfest. Also, I've not checked myself, but the patch appears to be failing for http://commitfest.cputube.org/ so it likely also needs a rebase. Thanks! Stephen --p3vPLop7SaiM7XTa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJaUUnRAAoJEO1sijiDR2RVPkcP/3Ulgdci6rDiEeOfrBaGzohQ I60Qi3RkFCaBfcBIFeVaumY8Gt4n76IDXXIUtDs9oPFaUbLqGqMZwj2et4sHZA4H /imUewZmPo/xXJb3IE6gjQ1a+SecQmuKDsfLoHWYBTc009tAU2AH0NIPaO1VImwO 13q4ztPfgT+xSPoTsr3VceQZpW8r4eN+8vVvRHGg9HiZhpvzJR2DAEtNDN8GJtQ2 ruOUQhok1ooSLOq6CjYyNqQ1QpO+8RrCy+THVEBdWIWStq4h/PlG+4WdkKqJzY0H KBaf2w1N3d/pyITRg9BXbHhSm5weN078lLj8onV+BRVSdyqDVQL+d7TceWAr5kuK hO9HxbllOWovrZF3XXxVYuhhZ3HvczQn6orL+BAID+0Tq2fzVFNgg+WmI3XWu7KP hqRB3yFFZxuMGS1q+atZ+mNPnmUFrym834pBQLRVhGJYH3fbf4Hjzus/GoLGS4vB M3scC61A2cxlmckou7eTRQO0Pu6lmMlgQGJX/Px1pSxEip+bQm1aftp7kubfWMxR h/cgwt2xiBHuce9UrBNDY2ynHu9r2+Gfyy/2fWiUUHbzlIOYjrI7miij2EM8irtU uwrL5zaZ7xkRqdWZviTnPFH+fOxHvTtxISCChLASUqrfEuoRALzqDlLg980vXuHm YMC1DupFyXc8d0Q/+WKO =dDjX -----END PGP SIGNATURE----- --p3vPLop7SaiM7XTa--