Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eZM8f-0004DK-LT
	for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Jan 2018 19:34:17 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eZM8e-0006KQ-OX
	for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Jan 2018 19:34:16 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <andres@anarazel.de>)
	id 1eZM8e-0006KF-EZ
	for pgsql-hackers@lists.postgresql.org; Wed, 10 Jan 2018 19:34:16 +0000
Received: from out3-smtp.messagingengine.com ([66.111.4.27])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <andres@anarazel.de>)
	id 1eZM8X-0002mB-JU
	for pgsql-hackers@lists.postgresql.org; Wed, 10 Jan 2018 19:34:15 +0000
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
	by mailout.nyi.internal (Postfix) with ESMTP id 6407320BEB;
	Wed, 10 Jan 2018 14:34:08 -0500 (EST)
Received: from frontend2 ([10.202.2.161])
  by compute5.internal (MEProxy); Wed, 10 Jan 2018 14:34:08 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-sender
	:x-me-sender:x-sasl-enc; s=fm1; bh=rQfW005mupwR0ZbUlNfKLpIi4IVNw
	BrUE8Ce29bfzdo=; b=KhaGca5hmByZk6XYlwSrSYw7pWEJwBGMZRHQQPPd41RwN
	koSPnFW/Ha65qnwj7rSj1Fl34O7W+GsCqZ7m1fdohnRafzWNMSPlYMetfAzUqrqQ
	NQ/BcWx/Rh/77AHSAitjrV2WE6Z1SOKw8Z8aVnT11Rts6FD4KXKMCDQlMzEWspfM
	Knt+u82uRvKq1axcyyUj//5gwcM1TMwrWNYS/DlD1XS1ZGgVnPHy3baYGHyrBe/Y
	DLmCHVv3UvX2QhzoEIVYrQjxWHLQpf75CWIxqfJc3yqiFoenU6quqZB3Gk9PF2rn
	gtQhgkjhqlIf1QtfZ056sWvYilnadpbI+hX9mkSoQ==
X-ME-Sender: <xms:sGpWWoHdRuRWRMuvX_HOznXHwkoQwM08FbpS5t7DnJDi4uZrhWB5XQ>
Received: from intern.anarazel.de (unknown [136.24.76.189])
	by mail.messagingengine.com (Postfix) with ESMTPA id 1CEB024235;
	Wed, 10 Jan 2018 14:34:08 -0500 (EST)
Date: Wed, 10 Jan 2018 11:34:07 -0800
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Dubious shortcut in ckpt_buforder_comparator()
Message-ID: <20180110193407.ub73iszdoi4zh233@alap3.anarazel.de>
References: <18437.1515607610@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <18437.1515607610@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Hi,

On 2018-01-10 13:06:50 -0500, Tom Lane wrote:
> So I think we should get rid of that micro-optimization, which is
> probably useless anyway from a performance standpoint, and do the
> comparison honestly.  Any objections?

No, absolutely none. You're going to change it?

Greetings,

Andres Freund