Date: Thu, 11 Jan 2018 15:49:00 +0900
From: Michael Paquier <michael.paquier@gmail.com>
To: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs
Message-ID: <20180111064900.GA51030@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0"
Content-Disposition: inline
Precedence: bulk


--6TrnltStXW4iwmi0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

While reviewing another patch related to the use of pg_strcasecmp in the
backend, I have noticed this bit in ruleutils.c:

    /*
     * Some GUC variable names are 'LIST' type and hence must not
     * be quoted.
     */
    if (pg_strcasecmp(configitem, "DateStyle") == 0
        || pg_strcasecmp(configitem, "search_path") == 0)
        appendStringInfoString(&buf, pos);
    else
        simple_quote_literal(&buf, pos);

However this fails to consider all GUCs marked as GUC_LIST_INPUT, like
the recent wal_consistency_checking. guc.c already holds a find_option()
which can be used to retrieve the flags of a parameter. What about using
that and filtering by GUC_LIST_INPUT? This requires exposing the
function, and I am not sure what people think about that.

Thoughts?
--
Michael

--6TrnltStXW4iwmi0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlpXCNwACgkQnvQgOdby
QH3geQ/9HtfpwpVibg+L6WKch9lVwDWS5w32BigBkHRvtxmvlOSdBx5i8QVewjSe
fDMqx04XEtVsvj/oSHKqeQEquMHMIfnjGjtNpRPSVspqNsoIEPZGoUcwpEr1D/QW
GSodkxRm+RC6056LSW1/E01Os7+JQPr7Sh0j1xkvGmWnkGAewqaxrHuxNYw12rX0
LFfSCFZQk79YDI5symcSmJAKiZf/i3ZB2bISCOInn2EKYdSeTeJj/6ieLgWHA5+G
OFfxDWyRjIMc7Iweb2FcoD9GkGFB1pnjF3/VRSvhbawCJOyoV6IpLg2gagA6p4v8
JLqRHwqn8PzqVZ1vkVHDwz5D19OCVk4hmErvVfEwg6X3fL3TJ7Fl9K3fm6QdmrUa
mr5b2SH7GghjUHgKY9tsq3C+BKBX1xQYYC1riRhb6l/r/9rScF04Iykrohn50XSp
Vr8Y9v/FX5r4pOBxuZMc0bugi9f19lFAWl9YpbgV3ysuTT/n8HPQL7ICwK97hi4X
At3EJuY2Sp+3fRH4C1bibJVkIV3q5C54pjU4Q5iPK0t9/OUzKjsCaBYPDxHJ/DrH
9vV7QdWwD8/njisir19NzYwBaEI1KKW1QomWfeQuvdo4JtZMM1dKni8yDWIHbhMG
ZUYGCC0PQMLHZjEDRYWWVHl7euwS1yFqhk4iynpPUvxlThd4PAk=
=TFFp
-----END PGP SIGNATURE-----

--6TrnltStXW4iwmi0--