Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZouP-0006mp-Jg for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Jan 2018 02:17:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eZouO-0006EB-VF for pgsql-hackers@arkaria.postgresql.org; Fri, 12 Jan 2018 02:17:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eZouO-0006E1-Oq for pgsql-hackers@lists.postgresql.org; Fri, 12 Jan 2018 02:17:28 +0000 Received: from tamriel.snowman.net ([96.255.250.162]) by magus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eZouH-0001Yp-QI for pgsql-hackers@postgresql.org; Fri, 12 Jan 2018 02:17:28 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id CD8DC5F79F; Thu, 11 Jan 2018 21:17:19 -0500 (EST) Date: Thu, 11 Jan 2018 21:17:19 -0500 From: Stephen Frost To: Tom Lane Cc: Robert Haas , Amit Kapila , Ildar Musin , Pg Hackers Subject: Re: IndexTupleDSize macro seems redundant Message-ID: <20180112021719.GU2416@tamriel.snowman.net> References: <0274288e-9e88-13b6-c61c-7b36928bf221@postgrespro.ru> <20180111172241.GK2416@tamriel.snowman.net> <8984.1515692863@sss.pgh.pa.us> <20180111181713.GN2416@tamriel.snowman.net> <20180111203250.GR2416@tamriel.snowman.net> <24410.1515712748@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JKJtp2LNXnKjc6hc" Content-Disposition: inline In-Reply-To: <24410.1515712748@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --JKJtp2LNXnKjc6hc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Tom, * Tom Lane (tgl@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Updated (combined) patch attached for review. I went through and looked > > again to make sure there weren't any cases of making an unaligned > > pointer to a struct and didn't see any, and I added some comments to > > _bt_restore_page(). >=20 > Looks OK from here. Great, thanks, I'll mark it as Ready For Committer then. Robert, since you were on this thread and the patch is mostly yours anyway, did you want to commit it? I'm happy to do so also, either way. Thanks! Stephen --JKJtp2LNXnKjc6hc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJaWBqvAAoJEO1sijiDR2RVDWgQAJoAEh1qD1+Usb9Zo87qxQMy tpOlp5f/wYnYsOWmwIl6YvClI0xkV4TWHYJjL608V98yON5/52PTEwNrT0ntfzmN vojZXwo8pc8vows+W/+UYACvnwMc9IurQ9V0i7pSfTDndDGjC4a4Wy3QBnjklK/7 wDX6wax0WiuXt13vuTYjs5aoX75Ufkp6Hhc8ZVggla0OHQo3WygOmi8en+J89s8N 21XErv0A0hwSHV7d7SHNw5n0dxehK8eywxz2OGXRkkC2GoQ6FYuzurJ6HOjBlX/s DE7h+zxrO+etwOeXv/6PptlRRjQ90TeskbcosAebycYGSF5zRcxdOlv/K95fiO99 Wzi874H55Tn1hJKBYg9/Uv83MxYNkXius9mP+kJ7zCSDc9YCIa5yfPIjMvkO8XKY QS51lgS66spNttnaL7IQZQKTyWTYFRAMe7tU5wtN9i3axhTXRgBmFCjVyePXITFY UCvBdMWTlpANb2+Ref4kfKDhNtWkzAKBQ7HNdJVvHmqTaLonZe7pK9lDhNXLPFe7 N4t1WIWR2I20AKvYkqErktmwJPpOpehameRoAY5xKdhG/mxDE9oPB+CPcS2apH+K j/vbY12Kx+8G/FKyUqu0gjQG4rivacLpauUhDXca7TY3n1YN9atCZKla3QyWLHkT h6jljTkdaZ4La61HNhsU =6PYn -----END PGP SIGNATURE----- --JKJtp2LNXnKjc6hc--