Date: Mon, 22 Jan 2018 22:34:29 -0500
From: Stephen Frost <sfrost@snowman.net>
To: =?utf-8?B?0K7RgNC40Lkg0KHQvtC60L7Qu9C+0LI=?= <funny.falcon@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>,
	Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	Claudio Freire <klaussfreire@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Sokolov Yura <funny.falcon@postgrespro.ru>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>,
	PostgreSQL-Dev <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Small improvement to compactify_tuples
Message-ID: <20180123033429.GF2416@tamriel.snowman.net>
References: 
 <CAGTBQpZgs4hVmDtHg4F6MDJuAE9-U=z6d+yJzjPsZup7AZhV0Q@mail.gmail.com>
 <22996.1510160560@sss.pgh.pa.us>
 <CAL-rCA3n4Neat4pH382nuZ9v0-SCZOBJ=KHT5CoBGXim=KTAhw@mail.gmail.com>
 <CAL-rCA2cCyvapkb15fADR3qKsRMo+XimPgmGviur1ui-y0q-aQ@mail.gmail.com>
 <CAH2-WznEQBxeij1_PnczUD=vQqS0aPWOxJAkmjH_rXoBpeo0ZQ@mail.gmail.com>
 <CAL-rCA3=MiVU7SWenhPL0a3e5KfOkzvXZDp_WL+ea2Ky57Fqdg@mail.gmail.com>
 <20171128224150.syswowiaiojth7ke@alap3.anarazel.de>
 <CAH2-Wzk19G5=RxQpgfUirRvihjrMvZSMSi=u53TbMbvLj1+5vA@mail.gmail.com>
 <CAB7nPqS4JRP_xyO3YCuBktGhTkDMRvg3-WBTgLqwpnLrtx-Qzg@mail.gmail.com>
 <CAL-rCA2n7UfVu1Ui0f+7cVN4vAKVM0+-cZKb_ka6-mGQBAF92w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gun6oyRuMjJjvP2a"
Content-Disposition: inline
In-Reply-To: 
 <CAL-rCA2n7UfVu1Ui0f+7cVN4vAKVM0+-cZKb_ka6-mGQBAF92w@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--gun6oyRuMjJjvP2a
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* =D0=AE=D1=80=D0=B8=D0=B9 =D0=A1=D0=BE=D0=BA=D0=BE=D0=BB=D0=BE=D0=B2 (funn=
y.falcon@gmail.com) wrote:
> On Wed, Nov 29, 2017 at 8:00 AM, Peter Geoghegan <pg@bowt.ie> wrote:
> > On Tue, Nov 28, 2017 at 2:41 PM, Andres Freund <andres@anarazel.de> wro=
te:
> >> Maybe it's a stupid question. But would we still want to have this aft=
er
> >> the change? These should be just specializations of the template versi=
on
> >> imo.
>=20
> "generic" version operates on bytes, and it will be a bit hard to combine
> it with
> templated version. Not impossible, but it will look ugly.

If that's the case then does it really make sense to make this change..?

> In attach fixed qsort_template version.
> And version for compactify_tuples with bucket_sort and templated qsort.

While having the patch is handy, I'm not seeing any performance numbers
on this version, and I imagine others watching this thread are also
wondering about things like a test run that just uses the specialized
qsort_itemIds() without the bucketsort.

Are you planning to post some updated numbers and/or an updated test
case that hopefully shows best/worst case with this change?  Would be
good to get that on a couple of platforms too, if possible, since we've
seen that the original benchmarks weren't able to be consistently
repeated across different platforms.  Without someone doing that
leg-work, this doesn't seem like it'll be moving forward.

Marking as Waiting on Author.

Thanks!

Stephen

--gun6oyRuMjJjvP2a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJaZq1FAAoJEO1sijiDR2RV9c0P+gLIevmNCkMzXum9x+Y/xhlu
LGGDEiA/1CVlsuSYuN0SbxKb+d2rd3ZiRYpPROZSwXs7kRTT2yf+lyzWP3Y08eXu
EHFlnqXhMcRsgBu39x3ZpWTVQ/gPJwDPWjvvosYBWxY4QldUSXMAC0BQfShs49hx
2L6WRHEb0aPNsaP5X29NdI9FXZCwgqgtRMPvNcBHAFV1sAk07QzG9hU5ZTmNlibB
8jr+Xuvf/J3WNgAPEp8Z0cVLRcKWwZ2LSbUt7IevJDmHUorAt7zex6cNQQjasLrM
8I0PYcsor/L8G+pf8UEP/tHAVkjGDFAyWlco3MYLXa/MTUzzq4yUfkxmRvenm4OL
jwfL1F8YgXgbiOYVgnCJO+q3N+EKrrNBwPrWin/ihMHXRgIV8pOyvvJyhFeuFo/N
DRJhMq0gOyC13xcQU6lQ7PSAau5Rp/gszz/mMEmPVVhdRM16M6SM9RgrLor29PhW
SHDX8V5QlQi6L97mtFNTK4dWUmHMFXNLm9MpNcq5XIlnBghpXoktBk6FU1gA5X5c
dXegM7XbPDmLlPswfkBAb+wY9vQ/db+HXJEj4oFT1XowJJBVtUdX55koL34HuF0/
yM8cDP1aiGC6VoFBHD37TF2qmEsPkO/pyqkpKM1F7rlvdumVlWvaiITjdMVLV8a8
IRpWiRMpONeqKmWlbs1o
=WP24
-----END PGP SIGNATURE-----

--gun6oyRuMjJjvP2a--