Date: Tue, 23 Jan 2018 10:37:11 -0500
From: Stephen Frost <sfrost@snowman.net>
To: Sergei Kornilov <sk@zsrv.org>
Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
Message-ID: <20180123153711.GI2416@tamriel.snowman.net>
References: <81911511895540@web58j.yandex.ru>
 <CA+TgmoZKR4dTR7KyoM4jfJN2J-eNoBRG2_XHdZa1f0VUbK1xXQ@mail.gmail.com>
 <20171129152135.GN4628@tamriel.snowman.net>
 <9878.1511970441@sss.pgh.pa.us>
 <370481511970756@web3j.yandex.ru>
 <491651511974381@web27j.yandex.ru>
 <CA+TgmoahVfu0dUmvM1bO3csn=DtFp1fG92995rjYD9u_kO-Y1g@mail.gmail.com>
 <369811512396584@web6o.yandex.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4etweliHmHX+n9SC"
Content-Disposition: inline
In-Reply-To: <369811512396584@web6o.yandex.ru>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--4etweliHmHX+n9SC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings Sergei,

* Sergei Kornilov (sk@zsrv.org) wrote:
> I update patch and also rebase to current head. I hope now it is better a=
ligned with project style

Thanks for updating it and continuing to work on it.  I haven't done a
full review but there were a few things below that I thought could be
improved-

> @@ -5863,8 +5864,11 @@ ATExecSetNotNull(AlteredTableInfo *tab, Relation r=
el,
> =20
>  		CatalogTupleUpdate(attr_rel, &tuple->t_self, tuple);
> =20
> -		/* Tell Phase 3 it needs to test the constraint */
> -		tab->new_notnull =3D true;
> +		if (!NotNullImpliedByRelConstraints(rel, (Form_pg_attribute) GETSTRUCT=
(tuple)))
> +		{
> +			/* Tell Phase 3 it needs to test the constraint */
> +			tab->verify_new_notnull =3D true;
> +		}
> =20
>  		ObjectAddressSubSet(address, RelationRelationId,
>  							RelationGetRelid(rel), attnum);

This could really use some additional comments, imv.  In particular, we
need to make it clear that verify_new_notnull only moves from the
initial 'false' value to 'true', since we could be asked to add multiple
NOT NULL constraints and if any of them aren't already covered by an
existing CHECK constraint then we need to perform the full table check.

> @@ -13618,15 +13662,14 @@ ComputePartitionAttrs(Relation rel, List *partP=
arams, AttrNumber *partattrs,
>  }
> =20
>  /*
> - * PartConstraintImpliedByRelConstraint
> - *		Does scanrel's existing constraints imply the partition constraint?
> + * ConstraintImpliedByRelConstraint
> + *		Does scanrel's existing constraints imply given constraint
>   *
>   * Existing constraints includes its check constraints and column-level
>   * NOT NULL constraints and partConstraint describes the partition const=
raint.
>   */
>  bool
> -PartConstraintImpliedByRelConstraint(Relation scanrel,
> -									 List *partConstraint)
> +ConstraintImpliedByRelConstraint(Relation scanrel, List *partConstraint)
>  {
>  	List	   *existConstraint =3D NIL;
>  	TupleConstr *constr =3D RelationGetDescr(scanrel)->constr;

I would also rename 'partConstraint' since this function is no longer,
necessairly, working with a partition's constraint.

This could also really use some regression tests and I'd be sure to
include tests of adding multiple NOT NULL constraints, sometimes where
they're all covered by existing CHECK constraints and other times when
only one or the other is (and there's existing NULL values in the other
column), etc.

Thanks!

Stephen

--4etweliHmHX+n9SC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJaZ1anAAoJEO1sijiDR2RVcX0QALE01GY22Vrq5tOiH0/3pYKr
5xjYwWlB71rbxbfEZNjcwGzdSl4IU6MXJ7z+DMjdIL7DxOCGNwjeouJO/Ab/8BIn
Awkn4Z/7k+HjEQebrVAHUM7H3S9VmepXs/36oiqvX1pBguxYXLdEuWMXw32tnp/a
GJMyzhVa4SsRzDKskj3t1hmg5iB1Avzrxfb9DGgljU8nQBN9qZpehu3Hb7BtLhdu
xkLcDaQ+4a5J990NtN5HIfZR/m51wsRLsRUh+nKTqve4+VPcrJFLCNFK3BB0WJYY
EruPAe2KKoIdwHzsq6hQqgdB8pBYclLJGFf26mV4TtaUZOeAbKA3+bOqwfCPOblG
l32Vq7FUfUNCeDF9874OUHLBpoKxBSXBHcoCPFqWDz6UeWyb9/6zDidcAZgyAH9G
0nc4lYktoALrAxl/4jzbhMFtknE+63bIqaqRQqktMim3lWKQyF/dzDymKivDk1X4
OVfwqUH5Cxu+mRH39/SBEiG9owOatyw3YhADAbRR19OfmOIf9IigXjEFbpkMURCm
cq9LxY2BDoWUvVXupv6DWWHDBt7X8s1BjPePiLtzKN8Gtg1YaUZPZ02mnCaAOTYR
15+eX5Z2IlbsBS7zu2DxL6mOtLMmIBcQnymM8SRUX7ZQqzEZxdA4kaOQcoASm9iB
61wUyqJGLyyFx3RsHZ06
=HAWn
-----END PGP SIGNATURE-----

--4etweliHmHX+n9SC--