Date: Mon, 29 Jan 2018 12:03:59 +0900
From: Michael Paquier <michael.paquier@gmail.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Robert Haas <robertmhaas@gmail.com>,
	David Rowley <david.rowley@2ndquadrant.com>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [Sender Address Forgery]Re: pg_(total_)relation_size and
 partitioned tables
Message-ID: <20180129030359.GA74483@paquier.xyz>
References: <8ecdd7fb-02d5-4322-526a-e49e2de25064@lab.ntt.co.jp>
 <20180119053958.GD12826@paquier.xyz>
 <7a9c5328-5328-52a3-2a3d-bf1434b4dd1d@lab.ntt.co.jp>
 <20180120101454.GA1311@paquier.xyz>
 <CAKJS1f-mffi=9Kjynns4L4Oc0YN7dJfB=SKyYZH-8bDZ5=q9qg@mail.gmail.com>
 <20180122024407.GA1772@paquier.xyz>
 <45b12bcf-5615-5ac9-1077-19d974087ace@lab.ntt.co.jp>
 <20180126124552.GJ17847@paquier.xyz>
 <CA+TgmoZ=eEPDkk2W+B12Cu_xVeWqys7X=b+2wZu7HD5qWj8jYQ@mail.gmail.com>
 <75294d6a-ff21-58a9-d4e6-56b412ef3ae5@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx"
Content-Disposition: inline
In-Reply-To: <75294d6a-ff21-58a9-d4e6-56b412ef3ae5@lab.ntt.co.jp>
Precedence: bulk


--dDRMvlgZJXvWKvBx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 29, 2018 at 10:08:51AM +0900, Amit Langote wrote:
> On 2018/01/27 3:32, Robert Haas wrote:
>> If it has
>> either partitions or inheritance children, find_all_inheritors will
>> return them.  Otherwise, I think it'll just return the input OID
>> itself.  So I don't quite see, if we're going to add a convenience
>> function here, why wouldn't just define it to return the same results
>> as find_all_inheritors does?
>=20
> So if all we're doing is trying to make find_all_inheritors() accessible
> to users through SQL, it makes sense to call it
> pg_get_inheritance_tables() rather than pg_partition_tree_tables().

I was looking again at this stuff this morning, noticing that
find_all_inheritors() is particularly used in
check_default_allows_bound() for partitions, so complaint withdrawn.
The renaming as you propose here looks sensible as well.
--
Michael

--dDRMvlgZJXvWKvBx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlpujx8ACgkQnvQgOdby
QH35HQ/9EgNxJFBSHpMysHZKbJdEV1MiyRqwRmNOJHF7lEnaM5X4qod0c8cwHGUv
ksUIFdk442ee0XUodIKvFjDA1NptxPy3thld3g0hdqYQjIQT5qhvVIJ50CLcIeF3
ABSUGsAr695VF1YxmKu85yWdkwnm2DLx4fMkGgp2c9D4igcDIbXe3bviIiaeOpyu
B/mCJ2xp18pY21PFgyLgyCl3+iblHsoGQi8ECgxWFZkSgyMd0igudvUtrPTjNuBS
Rd4JXHUcvow5Wkg7K3KG2d09qOZssvpTmotEFh4tQIu6P/gBGsQ8Uo9uR3F1I46p
DH86EbtHYQSlUi4yZ8Mig68ECQV1ADuDPcz9iUJfqoCmD68UNO6m/MbjkOofn7F4
HxZy86LeJTXqXKdPLy9WGi/U5WsA5dr3fhOgWXuwv57X7ZirZ/Jl5KZ4XPA3khJe
cr3XqvH1k2mNyczOFwNA9w7kzC7KSb0rMpOcpkJm4u3j/leVmlqINR8zB6uhEyCJ
YziGWdXsVZu7BfiSUOezxDOqxxQKdpBPpHEsCrcVh3fqUl99sSQREfRSouqF2i+i
Y3XENgPI1d20fL2M/gMaQj6lOlpzGgRqkZFWlhY1H/zAs+qS0X0OIx3R8+sUwnmv
IOTFarTw0zEYS3H7wAQLBlrqzGH7nJ/4nIAK8J8tL4NtlgCicYw=
=vWcZ
-----END PGP SIGNATURE-----

--dDRMvlgZJXvWKvBx--