Date: Thu, 22 Feb 2018 13:53:15 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
	Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: non-bulk inserts and tuple routing
Message-ID: <20180222165315.k27qfn4goskhoswj@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="3tbbsjhbeskclwx6"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+TgmoZYBc7HO6CfCTaksD40UyeM8+6_ShXs6XrYu5H0UC4SLQ@mail.gmail.com>
User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0)
Precedence: bulk


--3tbbsjhbeskclwx6
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Robert Haas wrote:
> On Tue, Feb 20, 2018 at 8:06 PM, Amit Langote
> <Langote_Amit_f8@lab.ntt.co.jp> wrote:
> >> Attached is an updated version for that.
> >
> > Thanks for updating the patch.
> 
> Committed with a few changes.

I propose to tweak a few comments to PartitionTupleRouting, as attached.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--3tbbsjhbeskclwx6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="comments.patch"

diff --git a/src/include/executor/execPartition.h b/src/include/executor/execPartition.h
index e94718608f..08a994bce1 100644
--- a/src/include/executor/execPartition.h
+++ b/src/include/executor/execPartition.h
@@ -58,11 +58,15 @@ typedef struct PartitionDispatchData *PartitionDispatch;
  *								partition tree.
  * num_dispatch					number of partitioned tables in the partition
  *								tree (= length of partition_dispatch_info[])
- * partition_oids				Array of leaf partitions OIDs
+ * partition_oids				Array of leaf partitions OIDs with one entry
+ *								for every leaf partition in the partition tree,
+ *								initialized in full by
+ *								ExecSetupPartitionTupleRouting.
  * partitions					Array of ResultRelInfo* objects with one entry
- *								for every leaf partition in the partition tree.
+ *								for every leaf partition in the partition tree,
+ *								initialized lazily.
  * num_partitions				Number of leaf partitions in the partition tree
- *								(= 'partitions' array length)
+ *								(= 'partitions_oid'/'partitions' array length)
  * parent_child_tupconv_maps	Array of TupleConversionMap objects with one
  *								entry for every leaf partition (required to
  *								convert tuple from the root table's rowtype to

--3tbbsjhbeskclwx6--