Date: Sun, 4 Mar 2018 21:40:26 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>,
	Robert Haas <rhaas@postgresql.org>
Subject: Re: Typo in src/backend/access/hash/README
Message-ID: <20180305034026.GC23634@telsasoft.com>
References: 
 <CAEepm=1_682z-09DNHj4GkCJAqWK-D6h9Oq5ea84T1oqq1-Utg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAEepm=1_682z-09DNHj4GkCJAqWK-D6h9Oq5ea84T1oqq1-Utg@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk

On Mon, Mar 05, 2018 at 04:30:28PM +1300, Thomas Munro wrote:
> Hi,
> 
> Not sure what word was missed here, but I guess "count":
> 
>  our the number of buckets stored in our cached copy of the metapage.  If
> -so, the bucket has certainly been split, because the must originally
> +so, the bucket has certainly been split, because the count must originally
>  have been less than the number of buckets that existed at that time and

I think there's a 2nd typo:

|After computing the ostensibly-correct bucket number based on our cached
|copy of the metapage, we lock the corresponding primary bucket page and
|check whether the bucket count stored in hasho_prevblkno is greater than
|OUR the number of buckets stored in our cached copy of the metapage.  If

remove "our"?

> --94eb2c0d4c02fe3e960566a1f43e
> Content-Type: application/octet-stream; name="somebody-accidentally-a-word.patch"

:)

Justin