Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1et1Sc-0005Ow-Iz for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Mar 2018 01:32:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1et1Sb-0002o2-0w for pgsql-hackers@arkaria.postgresql.org; Tue, 06 Mar 2018 01:32:09 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1et1Sa-0002ns-Mp for pgsql-hackers@lists.postgresql.org; Tue, 06 Mar 2018 01:32:08 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1et1SX-0000Nt-UO for pgsql-hackers@postgresql.org; Tue, 06 Mar 2018 01:32:07 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 1EAB91096; Mon, 5 Mar 2018 20:32:05 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Mon, 05 Mar 2018 20:32:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=RbaclK4fiud/KIND4KAHi6WZLTzE19jMp653M2Cf/Bo=; b=zN3b8lcv jEV11bZcQsbCn6NZoDCwMBEEteyM4xTVR+n4+TNfPyt6cGx5MmK3+ZCk0TflA9+f o7BLUpadh4Lw0C29uqjI8I607wp03yBG2SpwVE/NLtHQF9k4S0G4+xtylZwdc9bp rPIvZAQecX9z0g0ftu748pt9cmEDbvP/NW9aMiHvY94PsZ/bkO6m+ikJc+iWfA9/ vzoyZtRfuQ47PKZSweS/aa5s/wBaL14ftotxqS24dziJ2TgejAx2mH+jiGqdFY+V fN6Alc7U88FCg2ZxXt81jSIkK4wFwsZHAljyL4LBVxq1Hv6zpKzE4sd+5ndcyf54 eZvYzvemJkQ6tA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=RbaclK4fiud/KIND4KAHi6WZLTzE1 9jMp653M2Cf/Bo=; b=gRc+mWV0IZUMPs7UaL50Os01blj6JurtSLcq/L3SX2V37 Aw1DOruKtSQxpuFrmy8g+GloVk7l0+My3G5gGB/BGpFISpGAvmjF1O0OvcJuBqcc 6fX4QuuYwz9ulmWK45kTi7rqXjkiLTovFGwJDHZaly8eyOBUit30pxVu2s/wyWaq hTD9VTQMGv26igPTuGE5sX7sQ/Uj1UYKqaYGQAT1fpAESK+STJGGZ4Q3hbUL3STT XFuuJ3RQ5Qdsguy7t5ZNJWNIJePRAP+k6LM0L6Lnn5m4C+RCy4mRxAqrlbx+bt21 eIV+2jNWIbakzh9QO2qPMi5z1KVpWU2/ADGLK6brA== X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 53430246C8; Mon, 5 Mar 2018 20:32:03 -0500 (EST) Date: Tue, 6 Mar 2018 10:32:00 +0900 From: Michael Paquier To: Pavel Stehule Cc: Arthur Zakirov , Michael Paquier , Tom Lane , Postgres hackers Subject: Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs Message-ID: <20180306013200.GG1878@paquier.xyz> References: <20180111064900.GA51030@paquier.xyz> <13647.1515685358@sss.pgh.pa.us> <20180112012440.GA2222@paquier.xyz> <20180220154656.GA7518@zakirov.localdomain> <20180221073550.GA1632@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Dx9iWuMxHO1cCoFc" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --Dx9iWuMxHO1cCoFc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 05, 2018 at 09:25:09PM +0100, Pavel Stehule wrote: > I afraid so there is not good solution. Is possible to store options in > original form? When the function will be displayed, then the original value > will be displayed. The current patch (with known extensions) can be used as > bug fix and back patched. In new version we store original value with > quotes. You mean storing the values in pg_proc.proconfig at the creation time of the function? That would basically work, except for the case of a function using a parameter which is not from the same PL. The function creation would fail because it cannot find the parameter it is looking for as we need to look at loaded parameters to know it uses a list or not :( -- Michael --Dx9iWuMxHO1cCoFc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlqd75AACgkQnvQgOdby QH1p5RAAlqotKj/xuDq3mcy1qEule/1AxAJdYwUhJeNCi4gIBnV4n8NaIuLqlZc4 Zu7W+FGfAKSGIQ1llgOM2cRkGoVv8QhFN+nG5FZjIQ+mqVFdt6mTAPM2BKhXZhPN fcKakNECD5KiFA1kuIH7O3S/um88Pulvl/xu8j1RvI6mxofhaK5lDVyW5xtA7X+Y rq9UiTE870BQuDhCnsllhNOMGEl1d2BEktcAwnnBCHBDzcNd5MMJSVz1VPkx5HJz yodsb8edosMPoGATnlt5PoB9fGHZDwVJuJ3OLnirF0tj6W9r+hT/osvfNooEIFNb JfX8YDQ8pTlQacYzBJ4G0qR151BwZXCihmZdomqJYjEDOuI6OcnBRgsA1noWGLut 6XKqDt+84PbzplORSsFHkvEz6yt7bd354oAjhm/vkQlukKDHsK8IbdfKWYhzBghf YtCihYBwS93k9dwMribdasj51E2ei9BduXc1NZhnUfbLyTTxiYatf9UWNvwXUWwG H+qa5/FkDDKlkCbVO4FKDVmyXc86GK+lr4VO8DQT/4Ot73bJNeNNQVIG5wuDj0SF nPG7fjxt1wriJ/pIECwQcLdAqDViwQBP1hiUs9rsEihD0Yr2xFe+GEuKE5o5Toz2 aCQ3LKMhZdX4VL0XjqVWXRwrhvTqFUjCYDeROoCWTe3KEr0rVT4= =Ru6R -----END PGP SIGNATURE----- --Dx9iWuMxHO1cCoFc--