Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1f0Tom-0000A2-K5
	for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 15:13:52 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1f0Tol-0004ab-Gb
	for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Mar 2018 15:13:51 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <alvherre@alvh.no-ip.org>)
	id 1f0Tmf-00014N-98
	for pgsql-hackers@lists.postgresql.org; Mon, 26 Mar 2018 15:11:41 +0000
Received: from new1-smtp.messagingengine.com ([66.111.4.221])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <alvherre@alvh.no-ip.org>)
	id 1f0TmX-0008Fo-Ey
	for pgsql-hackers@postgresql.org; Mon, 26 Mar 2018 15:11:40 +0000
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
	by mailnew.nyi.internal (Postfix) with ESMTP id A4B3E11FE;
	Mon, 26 Mar 2018 11:11:29 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
  by compute4.internal (MEProxy); Mon, 26 Mar 2018 11:11:29 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-transfer-encoding:content-type
	:date:from:in-reply-to:message-id:mime-version:subject:to
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=FNNVu4zboSuT5XcAy
	7I4zxBxbjcF4Mg3vmjC3MRKslk=; b=SOOPhEnZVMA2jw5w2IAFUGNIVCu8aV6Eh
	Fsu3I/ZM/LOBBHWcse7cYYdrDpEv3u0YddyAipWgJ86h1nmSjgHE+xRuALj285b8
	oj775DGA0OdKCMZhzp839mhEZaG+PDu9cQtfCwrbryp/JQnusrNXH6lPxL1G9K9k
	P03HMOa56Gu0TlFlflVEk+o9d/FKRSbRmKR8A3mitWBfJ03bzb3ZeptIdibdaPyH
	rz/egl1HOMJPyXjUx242xViS3yVVWCK4Rm1DhJnDm9wZm8gmRvyvLrm5hES28uGm
	T6bKscvQn1xQQ6oqxtQLyGuwLiSUVKIbqaPQVZu9cdt5ywT5jErDQ==
X-ME-Sender: <xms:oQ25WvpyFAjWUsj3DD044TRt_rAxfnK4LIDmmFDPa8ClNjNoPGUGaA>
Received: from alvin.alvh.no-ip.org (unknown [179.56.51.182])
	by mail.messagingengine.com (Postfix) with ESMTPA id 1A88CE5086;
	Mon, 26 Mar 2018 11:11:29 -0400 (EDT)
Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000)
	id 611855A7; Mon, 26 Mar 2018 12:11:26 -0300 (-03)
Date: Mon, 26 Mar 2018 12:11:26 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: bugfifx: a minor mistake in brin_inclusion.c comment
Message-ID: <20180326151126.6bouh22l4n3ynwcy@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5ff514f2-8b1e-6366-b11c-8e2ed442562d@2ndquadrant.com>
User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Tomas Vondra wrote:
> Hi,
> 
> while looking at brin_inclusion.c, I've noticed that the comment about
> INCLUSION_UNMERGEABLE and INCLUSION_CONTAINS_EMPTY uses incorrect values
> (1 instead of 2). Attached is a simple fix.

Uh, yeah, this is wrong.

> But perhaps it would be better to use the constants in the comment.

I fixed it like this, which seems neater.

Thanks!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services