Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3m6A-0000Z4-FJ for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 17:21:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3m68-0004lp-Un for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 17:21:24 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3m68-0004le-K4 for pgsql-hackers@lists.postgresql.org; Wed, 04 Apr 2018 17:21:24 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3m61-0003aC-L3 for pgsql-hackers@postgresql.org; Wed, 04 Apr 2018 17:21:23 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 1CF01F31; Wed, 4 Apr 2018 13:21:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 04 Apr 2018 13:21:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=rzPoI+UrwVeYavCkV zMUuOhK7hjesSxiZkotq9oYnuY=; b=jb+WWqz2uYvX+3xW1lIzGOSlQEmk9QMZN t+Vo4w3L7tpwobXyESiVqJBtRkC+gFusxvhkxiYjW+KhqLcg6GbXYuv4ct8Z+1q5 pQBGj8Q1KaFsWpYFc7ZwuKJucgiRtQwdcLCPE2twCsTL+eJbSJ5mpFLFcVQ/CasE 19MTribf+fGc0BfI7efSD9kC8oU6S3fTfIoyS2w1rntbGpdbI7ArR/gUzY9aU1Hd 41/4OohLBGgHFGtXJYVV+w4MOHyT2eo88qrxZgumeRSkxlBc8G4USIUqd9lhT+Vx nfMmMhYcCU7HaWAw1OoiQbsFlePIealG5RARtgPVKR9vF1njIXEpg== X-ME-Sender: Received: from alvin.alvh.no-ip.org (unknown [179.56.29.253]) by mail.messagingengine.com (Postfix) with ESMTPA id 69F4CE43C8; Wed, 4 Apr 2018 13:21:16 -0400 (EDT) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id F15E25A7; Wed, 4 Apr 2018 14:21:14 -0300 (-03) Date: Wed, 4 Apr 2018 14:21:14 -0300 From: Alvaro Herrera To: Peter Eisentraut Cc: Pg Hackers Subject: Re: Foreign keys and partitioned tables Message-ID: <20180404172114.vdclwe4lxlt4c6fd@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Peter Eisentraut wrote: > On 4/3/18 15:11, Alvaro Herrera wrote: > > 0003 is the main patch, which is a bit changed from v4, notably to cover > > your review comments: > > Looks good now. Thanks, pushed. I added a couple of test cases for ON UPDATE/DELETE and MATCH PARTIAL, after noticing that ri_triggers.c could use some additional coverage after deleting the parts of it that did not correspond to partitioned tables. I think it is possible to keep adding tests, if someone really wanted to. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services