Date: Fri, 6 Apr 2018 21:31:08 -0700
From: Andres Freund <andres@anarazel.de>
To: Amit Langote <amitlangote09@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
	Jesper Pedersen <jesper.pedersen@redhat.com>,
	Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
	Beena Emerson <memissemerson@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>, amul sul <sulamul@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: [HACKERS] Runtime Partition Pruning
Message-ID: <20180407043108.csphvmzyk4gprnze@alap3.anarazel.de>
References: <20180406212507.6ddl76zkhd2ze4p5@alvherre.pgsql>
 <20180406212917.zzq5dbmasyt3fwru@alvherre.pgsql>
 <CAKJS1f88oG+RPaFCxFf4=omk8KfVZCrWuBHXazag4zGBinagBA@mail.gmail.com>
 <CAKJS1f99JnkbOshdV_4zoJZ96DPtKeHMHv43JRL_ZdHRkkVKCA@mail.gmail.com>
 <CAKJS1f-42TXEo1DLZ_FXBNiRuJ3=Oy-Z5V8_0WkL0_Ast=9saw@mail.gmail.com>
 <CA+HiwqHAKp4=jSQH3WWL4+s3=qWrCaCnBCu-zx4eZ_Tqn6g4DQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+HiwqHAKp4=jSQH3WWL4+s3=qWrCaCnBCu-zx4eZ_Tqn6g4DQ@mail.gmail.com>
Precedence: bulk

On 2018-04-07 13:26:51 +0900, Amit Langote wrote:
> On Sat, Apr 7, 2018 at 11:26 AM, David Rowley
> <david.rowley@2ndquadrant.com> wrote:
> > Everything else looks fine from my point of view.
> 
> Me too, although I still think having struct names PartitionPruning
> and PartitionRelPruning is going to be  a bit confusing.  We should
> think about naming the latter to something else.  I suggested
> PartitionPruningDispatch(Data), but David doesn't seem to like it.
> Maybe, PartitionPruneState, because it parallels the
> PartitionPruneInfo that comes from the planner for every partitioned
> table in the tree.

I've not followed this thread/feature at all, but I don't find the
comments atop partprune.c even remotely sufficient. Unless there's an
README hidden or such hidden somewhere?

Greetings,

Andres Freund