Date: Tue, 17 Apr 2018 12:28:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@postgresql.org, simon@2ndquadrant.com
Subject: Re: SHOW ALL does not honor pg_read_all_settings membership
Message-ID: <20180417032858.GD4998@paquier.xyz>
References: <1519917758.6586.8.camel@cybertec.at>
 <1523881930.3779.37.camel@cybertec.at>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9dgjiU4MmWPVapMU"
Content-Disposition: inline
In-Reply-To: <1523881930.3779.37.camel@cybertec.at>
Precedence: bulk


--9dgjiU4MmWPVapMU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 16, 2018 at 02:32:10PM +0200, Laurenz Albe wrote:
> Now that the dust from the last commitfest is settling, I'll make a second
> attempt to attract attention for this small bug fix.
>=20
> The original commit was Simon's.

Thanks for the ping.

This was new as of v10, so this cannot be listed as an open item still I
have added that under the section for older bugs, because you are right
as far as I can see.

GetConfigOption is wrong by the way, as restrict_superuser means that
all members of the group pg_read_all_settings can read
GUC_SUPERUSER_ONLY params, and not only superusers, so the comment at
least needs a fix, the variable ought to be renamed as well.
--
Michael

--9dgjiU4MmWPVapMU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlrVafoACgkQnvQgOdby
QH3Rcw//R5oHgazY/ij3qd2lJc9WPu9lXmEPLtTgZnudcAwUJytLrHRTaCNaoQtZ
f4GbTZozNeNq0FMUWBdbYiJ3NylPcBMqUnSVCnGzFfFQm8JP6Tan462NdBaDDrLA
9jcWOFZdrQINPt7Tb2IS6qdKc6BC4J42MgGEbnHUkEZDqUhZ6SpByDIpFOHsUOKs
DskDnnkc6k6c5WiucrLczjl137j896wa/3bXZ6bbUDLAQSu7lg2/9R40blZCppfB
8sKoNt+PJo+ycgv1Ajp8LKNPbpuMsr3gEiqrMlnGymBlZCFp7qqTDy3gpbalecDf
TETfteN9dS6X6uk54G1Cg6fjq3el3ZJSxEqXJ/8BSHrWLnZYOnQ3L++40d35aTx0
h2FmulpO2pmXVDjyHevDw2HCg++lTbIQuEbqd8zdplmITOShTgVF3VIcKc3NalY6
N2wzq1hB8sRiVRjgfiZ6z+H2LWBDaJX6JqmmU/0vZHf+S2n2Yp7fSWDenwTWhp44
/8u/muG2NIeEFlMHMCkDV3q2klGCiDRA9yGr1Ce/iXt0lc+fQiTX2Rti5GtihL/3
bwPGWhoc/m3Fl2xEN6DgPAOGxjfw0cSnl/6+a9wUlNaQXSvLakyWiqEvxAndlSni
690itm+iJr5uZ9h89xc6JAZThhvF6V4XG0egd18W5yYaEHcGBRY=
=upE8
-----END PGP SIGNATURE-----

--9dgjiU4MmWPVapMU--