Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f9DF7-0004xc-0Q for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Apr 2018 17:21:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f9DF5-00005q-Bk for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Apr 2018 17:21:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f9DF4-00005g-Eh for pgsql-hackers@lists.postgresql.org; Thu, 19 Apr 2018 17:21:07 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f9DEy-0006Ad-6D for pgsql-hackers@postgresql.org; Thu, 19 Apr 2018 17:21:05 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 3D9C816C4; Thu, 19 Apr 2018 13:20:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 19 Apr 2018 13:20:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+2SxVovfaAnWJNJRu +29mwY3aVbgKG+jEFgx2jGI720=; b=nMDnqkvOyFQUDl5rtyRH0Fvedo7LXZVd9 Br2ULHGw/sHneu3VadincOkiVnuNNomdOiL+4UlR/545aGoxojVY0dgARXV6oGwn 1IsKohmkoc6/V67EGJpUP2wVZquLuUROmZ4r/hAzrwt+5y1bU5JnMnnSRbCYbBBc ah1uq6OsMlA30eR/C0XTDcyWW7nHtsyHi3tNDSHS8WUEY+gcL3RWYEOxbGYvMd/C dTvoCRl4BmORLhO9vjDlktEE6ic2UUstY79ckNN+kcq2kDc8S13U8KCFN4TEtmE2 MDPxQbfsflj1nCUk8xrGei+0OpTdJjnkuYk6TzSYtG00xCm2PFBmQ== X-ME-Sender: Received: from alvin.alvh.no-ip.org (unknown [179.56.51.182]) by mail.messagingengine.com (Postfix) with ESMTPA id 8D5AAE4437; Thu, 19 Apr 2018 13:20:56 -0400 (EDT) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 72A0432D; Thu, 19 Apr 2018 14:20:54 -0300 (-03) Date: Thu, 19 Apr 2018 14:20:54 -0300 From: Alvaro Herrera To: Amit Langote Cc: Pavan Deolasee , Etsuro Fujita , Andres Freund , Pg Hackers , Peter Geoghegan Subject: Re: ON CONFLICT DO UPDATE for partitioned tables Message-ID: <20180419172054.3ei6gf55kuu2ofyk@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0fa64646-b9a4-85ba-8847-d3acdbd89d0e@lab.ntt.co.jp> User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Amit Langote wrote: > Yeah, I too have wondered in the past what it would take to make > equalTupDescs() return true for parent and partitions. Maybe we can make > it work by looking a bit harder than I did then. How about simply relaxing the tdtypeid test from equalTupleDescs? I haven't looked deeply but I think just checking whether or not both are RECORDOID might be sufficient, for typecache purposes. If we just remove the tdtypeid test, check-world passes. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services