Date: Sat, 28 Apr 2018 08:16:42 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Stas Kelvich <s.kelvich@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: FinishPreparedTransaction missing HOLD_INTERRUPTS section
Message-ID: <20180427231642.GA2124@paquier.xyz>
References: <3AD85097-A3F3-4EBA-99BD-C38EDF8D2949@postgrespro.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV"
Content-Disposition: inline
In-Reply-To: <3AD85097-A3F3-4EBA-99BD-C38EDF8D2949@postgrespro.ru>
Precedence: bulk


--HcAYCG3uE/tztfnV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 28, 2018 at 12:36:16AM +0300, Stas Kelvich wrote:
> It seems that during COMMIT PREPARED FinishPreparedTransaction() doesn't
> hold interrupts around writing to wal and cleaning up ProcArray and GXact
> entries. At least RemoveTwoPhaseFile (which is called in between) can pri=
nt
> a warning with ereport(), which, in turn will check for interrupts and
> therefore can cancel backend or throw an error before GXact clean-up.
>=20
> Other similar places like CommitTransaction and PrepareTransaction have
> such hold interrupts sections.

Good catch!  The places you are suggesting look good to me as well.
That's something which should be back-patched as well.
--
Michael

--HcAYCG3uE/tztfnV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlrjr1oACgkQnvQgOdby
QH2hXg//bZr3ehPRyssSIo/2fUNaX0/mwDU6HLrjWy+LLeVAXY6jvwH/CmgX/AYc
TCiOvESVE/UIM2WnPy1cUM4FBf8AJJ2QeeNcnisR0Xb2JzqW4yHhEQP6m09ubVTI
ckQuFTZXl5+LITJp5eAO2GA447HD/N82jHdimCYkUHfqgyJUInKgZ3ZMLUAo25bH
STSzjFAjFllUS5OIu3bNOI4HN7Zss2m3fqz9NJPa1lub0H2ygwlhaPt99HEuy+zA
PWNpiXXz/PK6k92OVrlSLH45NKY1VQPKf/uqbvzjrXBIyAaR+OnLC3LXwKjbjCNU
iQ6jXfw+3iTs9/x3aIBVqUlChdK6o6VXBcnPIeE0sStcGq3tdWt3Dknq+sWG4Leb
Dm3y8Mc5pDx08HX1pAQ29GrGuNpKKjufrx7APOj3Fo8jggqcnes9bJGRTQClgT5/
sWQLRseFqoIvUzBQWLDaVxxzTtWW5sMfr/HeT/vWw5EwSfS1kpzq6MfgDG4B+y4O
tS8i1ZumSZl9R1hJkhvRaZra7v8p3L6joOpJ+Bp5U6owBepwiPVRp6dZElBOkxDp
QOZARL+Kf07Ci1EHbYrSRompwRzcTA/5A939gIZWAnsQwDpeEzSisSrgccAJrMMi
ijN4qcQqVc8AnahEgs+oh4Y99YTMR22lUObsccxwLUkwaUcF9nQ=
=+Bg4
-----END PGP SIGNATURE-----

--HcAYCG3uE/tztfnV--