Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fG8PZ-0003fk-HQ for pgsql-hackers@arkaria.postgresql.org; Tue, 08 May 2018 19:36:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fG8PX-0000IX-OC for pgsql-hackers@arkaria.postgresql.org; Tue, 08 May 2018 19:36:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fG8PX-0000IN-DH for pgsql-hackers@lists.postgresql.org; Tue, 08 May 2018 19:36:31 +0000 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fG8PT-00039m-GQ for pgsql-hackers@postgresql.org; Tue, 08 May 2018 19:36:30 +0000 Received: by mail-qk0-x244.google.com with SMTP id z8so25651713qki.11 for ; Tue, 08 May 2018 12:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=fS7pdZQrf+rx16QmAiclGMy3D3PHeJizEQz84Vfjdag=; b=luXK9ag7nsHwGay037Td0/Ppa0b4mGfhJV9W6VfxxatFCb83JfP2tm3WLbl11bEiWP p9sodkj92mZLselvOnlPMV6YMSngiNpadiBKV5DO12mnyXWMnfB/d6MYgnwTHLcdgx9f A2sn9G20zlGz8NbzFxnRFJWnEu0Z0JoZyHwaGS5iQxBMNSzOsvqv48xqqUywPYVYoZDe yRHKJZ8K+kDzdmkWqgvO65Kpl7/mFKrcGHCWGNfY/YWjHAv7qQGudc9oB8jZfnLyoPla DJTqA0XducEelMp1v4cOkf74slpG1+XE0CeCIY+FFYI4Ylm0z5T/59GzruZMWLP5PF69 I6Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=fS7pdZQrf+rx16QmAiclGMy3D3PHeJizEQz84Vfjdag=; b=O4RhmL/VcLT80PPCbZleOFEDMTtZjvOIJPKihxCnUJEt05IRwnUaikQFzyF6icb7Qb uJbk+O0KcA+ROfS1gKQ0dmJCxA/LRvyXauA0VcBDM+MfQlWYJgqcgsU8Q4w0wIn5ztFK 1OxYNA1OoogdmwZia5XRNvo82aNO7oIKWuIYK5ayAtszRp+e0eHX8nkBOtqxbmLdGZhX U+AmTrTPKMhrV43XAZRSgTGxRoXJQBeh0cGKlowrXJb/V5amqXlYlaPdv/JIhtEB1hIy Ime9XoavEl4Ech9SSTotw8D7I0tP/FwG4naRUxQQxxdcQQrTDn41/B8R3v5c8rEFAZZY UVlg== X-Gm-Message-State: ALQs6tAEbjUxzHzh7zFh5aRkjJOaPHoU77u1ykD0SgWyu3PrTFDtPyr0 JFX8NIWOQRa8TOTErVyh4aFRhC5A X-Google-Smtp-Source: AB8JxZorIbOsDWoZrBPfGnxRv7jwYZQnYnAMrEyRhg2EoZMNMrvgOskyQNlfaU5jTXL3U+9bfA2Vbw== X-Received: by 10.55.72.141 with SMTP id v135mr35417071qka.353.1525808185171; Tue, 08 May 2018 12:36:25 -0700 (PDT) Received: from alvin.alvh.no-ip.org ([179.56.29.253]) by smtp.gmail.com with ESMTPSA id v56-v6sm21615263qtc.96.2018.05.08.12.36.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 May 2018 12:36:24 -0700 (PDT) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id AE2085CC; Tue, 8 May 2018 16:36:21 -0300 (-03) Date: Tue, 8 May 2018 16:36:21 -0300 From: Alvaro Herrera To: Fabien COELHO Cc: Marina Polyakova , Ildus Kurbangaliev , pgsql-hackers@postgresql.org, Teodor Sigaev Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors Message-ID: <20180508193621.dphlgwrd5yz67o2z@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hello, Fabien COELHO wrote: > > Looking over the diff, I find that this patch tries to do too much and > > needs to be split up. > > Yep, I agree that it would help the reviewing process. On the other hand I > have bad memories about maintaining dependent patches which interfere > significantly. Sure. I suggest not posting these patches separately -- instead, post as a series of commits in a single email, attaching files from "git format-patch". -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services