Date: Sat, 19 May 2018 06:02:10 +0530
From: Abhijit Menon-Sen <ams@2ndQuadrant.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Craig Ringer <craig@2ndquadrant.com>,
	Thomas Munro <thomas.munro@enterprisedb.com>,
	Simon Riggs <simon@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Postgres, fsync, and OSs (specifically linux)
Message-ID: <20180519003210.xehe2kfei5nss4mw@toroid.org>
References: 
 <CAMsr+YGq5CdhTB_OScCraSf0__vk6nFVhpp6fONOfOZAZKG=rQ@mail.gmail.com>
 <CAMsr+YF=FfuNCcBJXV4tDsxQQ=Yu5GfhZ-z6iiu+Y4x2MYzX0Q@mail.gmail.com>
 <20180430160945.5s5qfoqryhtmugxl@alap3.anarazel.de>
 <CAMsr+YGsvYmJ0aRuV7zNf-rmi53bzFF8yrsgrNBm9yOY8FYD0g@mail.gmail.com>
 <20180509225555.rmk3azmgrwfwudw5@alap3.anarazel.de>
 <CAMsr+YEcv3gvLHX-gTMnA0Z_YCChJ+rCMTGnx1aQMUFmp4Lvbw@mail.gmail.com>
 <20180517164440.szk6vhbdprcm462a@alap3.anarazel.de>
 <CA+Tgmob0sD3BGo46ZXK4hJw=2NDco10Zsx=rzTMxVXY0kHRvxg@mail.gmail.com>
 <CAFjFpRco+fapy2383raQhzNJRpVivEcSxFBxL5M-4YJZ8T-wbg@mail.gmail.com>
 <20180519002757.GU27724@tamriel.snowman.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180519002757.GU27724@tamriel.snowman.net>
Precedence: bulk

At 2018-05-18 20:27:57 -0400, sfrost@snowman.net wrote:
>
> I don't agree with the general notion that we can't have a function
> which handles the complicated bits about the kind of error because
> someone grep'ing the source for PANIC might have to do an additional
> lookup.

Or we could just name the function promote_eio_to_PANIC.

(I understood the objection to be about how 'grep PANIC' wouldn't find
these lines at all, not that there would be an additional lookup.)

-- Abhijit