Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fJqFV-0005Tv-Tf for pgsql-hackers@arkaria.postgresql.org; Sat, 19 May 2018 01:01:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fJqFT-0008Jk-Kl for pgsql-hackers@arkaria.postgresql.org; Sat, 19 May 2018 01:01:27 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fJqFT-0008JZ-AG for pgsql-hackers@lists.postgresql.org; Sat, 19 May 2018 01:01:27 +0000 Received: from tamriel.snowman.net ([2001:470:e38f::11]) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fJqFP-0000D6-Lg for pgsql-hackers@postgresql.org; Sat, 19 May 2018 01:01:25 +0000 Received: by tamriel.snowman.net (Postfix, from userid 1000) id E96755F79C; Fri, 18 May 2018 21:01:21 -0400 (EDT) Date: Fri, 18 May 2018 21:01:21 -0400 From: Stephen Frost To: Abhijit Menon-Sen Cc: Ashutosh Bapat , Robert Haas , Andres Freund , Craig Ringer , Thomas Munro , Simon Riggs , PostgreSQL Hackers Subject: Re: Postgres, fsync, and OSs (specifically linux) Message-ID: <20180519010121.GV27724@tamriel.snowman.net> References: <20180430160945.5s5qfoqryhtmugxl@alap3.anarazel.de> <20180509225555.rmk3azmgrwfwudw5@alap3.anarazel.de> <20180517164440.szk6vhbdprcm462a@alap3.anarazel.de> <20180519002757.GU27724@tamriel.snowman.net> <20180519003210.xehe2kfei5nss4mw@toroid.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="L/NyhHcOD2V9m72V" Content-Disposition: inline In-Reply-To: <20180519003210.xehe2kfei5nss4mw@toroid.org> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --L/NyhHcOD2V9m72V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Greetings, * Abhijit Menon-Sen (ams@2ndQuadrant.com) wrote: > At 2018-05-18 20:27:57 -0400, sfrost@snowman.net wrote: > > > > I don't agree with the general notion that we can't have a function > > which handles the complicated bits about the kind of error because > > someone grep'ing the source for PANIC might have to do an additional > > lookup. >=20 > Or we could just name the function promote_eio_to_PANIC. Ugh, I'm not thrilled with that either. > (I understood the objection to be about how 'grep PANIC' wouldn't find > these lines at all, not that there would be an additional lookup.) =2E.. and my point was that 'grep PANIC' would, almost certainly, find the function promote_eio_to_panic(), and someone could trivially look up all the callers of that function then. Thanks! Stephen --L/NyhHcOD2V9m72V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJa/3dhAAoJEO1sijiDR2RVW64QAKXi6Hx+VT7Dsis+lS7ngfMt WxMcd7zfytKF5S0cVdpOThdTZ46tY2l5bRQQV+HE4Q38sKqnzO2RJW0t34rmlIse HLma7L7jJ5RbB97w7Mw0fiCK5md8W2oGPVSyrhEPNYxO6lAqgj7Zt4gBV++EY097 FmhceFYlRdhcRKjk4fQZyo7wVB4SwHdS5kX7rBYx3u6pRNIRqxiN4UhBASj7dYUZ 1RwpYNQOROErGrOQrU8zEWwkAGQRy+0whmDtFA4o7sEPCMZ6Iup3Tr45uipcTImi Byh37kRPKWOkisiBzbb+nLCgJSfY46jG0d29VQNDqklcYvCPkzVv1eggi1aTlUV2 WnckOEmcBh+f+F/ywDWObZt2wpNx2CiE8/e43w1pIG7fmm56g2/+10tVLT/pQQTk k4BM2dKTL7wpOSajNVq848dETwbczQ76CaF3h5tU48hW2oqk6/QT2roAVwYQl59b 1GXEvW2jAiyPtio0ugyNwJTnMGHH+inLUwteI7o/IwH9UfCrBRPliT7+bqKV/62a ljgeY8Qr2+zTTY4FDms3uU4kKMH9zgLSd4mmJGC4213GJaJhvWvIvjrSKOoFZRAm omDcLyjSemyc92gwpGRtLP6l4r3Ie8TwnFvhMU6wNNRpR0/AIKHUvLDqeQ19C6tk rBHqXuqU3PYU83MRSOW3 =te1T -----END PGP SIGNATURE----- --L/NyhHcOD2V9m72V--