Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fRO78-0007j5-Sz
	for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Jun 2018 20:36:03 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fRO77-0005p6-NK
	for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Jun 2018 20:36:01 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1fRO77-0005or-FY
	for pgsql-hackers@lists.postgresql.org; Fri, 08 Jun 2018 20:36:01 +0000
Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <alvherre@2ndquadrant.com>)
	id 1fRO73-0003Pz-UR
	for pgsql-hackers@postgresql.org; Fri, 08 Jun 2018 20:36:01 +0000
Received: by mail-qk0-x243.google.com with SMTP id y4-v6so9563636qka.5
        for <pgsql-hackers@postgresql.org>;
 Fri, 08 Jun 2018 13:35:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:mime-version:content-disposition
         :content-transfer-encoding:in-reply-to:user-agent;
        bh=+IVJO7HB+CvXdNfNXlevjCpe2QzlQm6a7nVuMvh9ZSM=;
        b=pRqVAdqcC6TORPm6gC1uSLYO31WztOre9co2KQebm1VIu0l2FV1KycX0aXI73eBUxb
         2J6o3N0/knFSA6+rKzG3miauf98pMj1FAQAeaUA/34noMmHYvzOcEXSabhcpvfz9VGJX
         iTQ72C2XI35rO9xU+3rG6faIzz1LJMXE4sAzMWw1kt1kbYfyyWZCFyLeuMDbGvAuX91K
         r8Y9ZqRvqUGk5mdj6tsNt8yjPdiptNYq3X9CZTTI4mSXMwJ0s9mspqy9Duh/Ziy/bqBs
         fcblFgGELZEBtsfq3zMvC5HYJVPfP8szvTdESgJlmtpG7YDKDvBFTKID/gp0og3I6xcQ
         XrEg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=+IVJO7HB+CvXdNfNXlevjCpe2QzlQm6a7nVuMvh9ZSM=;
        b=NIjeWf7VGXoEWWa8e5AF0CaqYQCyp7yxaVb5zoUNzUblbehXmsxKKXMm0qPogrn2E3
         /j06HBU0V4a5psMkKel94PH8/5IUc7yzxE9+PW4TUEV3BGoru9zUybznv8S7yPaA8pip
         aj/CTn6yzHN8gKO2bQmM9rwReM0tuARmhH03zT4bi7QNhpV7jDUzg2dAPKbTA1Vx9vHS
         cKrlezMVuHZidEHo5swuIheACOI1w4OzUwqASkIwKZaS0iFiCY/X4SaZ9uLf5VVt9V2M
         68i9uZUHEZXaKkKL4GRClAGnKC06s0Y9bR3d1B8cWXhKqUADUm6b1guUqT9J1KDU2zf1
         OqVA==
X-Gm-Message-State: APt69E2MhEMAez1VdMSwNvAubPfgR2A2XgZRsqLRRFWZz3Dv0RhIys1T
	x430ilGgJI0URsteSvCGs2gJCQ==
X-Google-Smtp-Source: 
 ADUXVKL+LGiX84o0obMxro4K/UYxS19UWxjYCpzwTay0kxc4wkHn/OvUpnE5yifCSZtEzC3E38LrXg==
X-Received: by 2002:a37:28c4:: with SMTP id
 o65-v6mr6732062qko.200.1528490155873;
        Fri, 08 Jun 2018 13:35:55 -0700 (PDT)
Received: from alvin.alvh.no-ip.org ([190.217.216.192])
        by smtp.gmail.com with ESMTPSA id
 29-v6sm48051245qto.42.2018.06.08.13.35.54
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Fri, 08 Jun 2018 13:35:55 -0700 (PDT)
Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000)
	id 4A76D59F; Fri,  8 Jun 2018 16:35:52 -0400 (-04)
Date: Fri, 8 Jun 2018 16:35:52 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@postgresql.org
Subject: Re: SHOW ALL does not honor pg_read_all_settings membership
Message-ID: <20180608203552.fucesylemcaig7ju@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1519917758.6586.8.camel@cybertec.at>
User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On 2018-Mar-01, Laurenz Albe wrote:

> I noticed that commit 25fff40798fc4ac11a241bfd9ab0c45c085e2212 forgot
> to teach SHOW ALL to show all GUCs when the user belongs to pg_read_all_settings.
> 
> Patch attached; I think this should be backpatched.

Done, with the further fixes downthread.  Thanks!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services