Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fSVnk-0004vP-I6
	for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Jun 2018 23:00:40 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fSVni-0008Hw-BN
	for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Jun 2018 23:00:38 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <nico@cryptonector.com>)
	id 1fSVnh-0008HR-OO
	for pgsql-hackers@lists.postgresql.org; Mon, 11 Jun 2018 23:00:37 +0000
Received: from homie-sub4.mail.dreamhost.com ([69.163.253.135]
 helo=homiemail-a131.g.dreamhost.com)
	by makus.postgresql.org with esmtps (TLS1.1:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <nico@cryptonector.com>)
	id 1fSVnc-0006f0-B1
	for pgsql-hackers@postgresql.org; Mon, 11 Jun 2018 23:00:34 +0000
Received: from homiemail-a131.g.dreamhost.com (localhost [127.0.0.1])
	by homiemail-a131.g.dreamhost.com (Postfix) with ESMTP id 11D4D60002E37;
	Mon, 11 Jun 2018 16:00:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=cryptonector.com; h=date
	:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; s=cryptonector.com; bh=ONuQtBaSF9csgF
	AQIt2eLKbWESY=; b=XrhhAl2RUwp+PXNRWm+H+9uy2KFzaOMlXTVBQ1k0aBwetF
	sjSNeQ1FxkAd6EOQ1o8z5lESYZyRiL/2cQ6Fpii0rEwYKKZevaPA+DkwUTK/dN8t
	Gj1ZGmfmmvZ94xd6A0WGeCSnrpSc/dhomyc2IyNQQrxfCs21PnWNavfIKtFJ8=
Received: from localhost (cpe-70-123-158-140.austin.res.rr.com
 [70.123.158.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: nico@cryptonector.com)
	by homiemail-a131.g.dreamhost.com (Postfix) with ESMTPSA id C22BC60002E1A;
	Mon, 11 Jun 2018 16:00:29 -0700 (PDT)
Date: Mon, 11 Jun 2018 18:00:27 -0500
From: Nico Williams <nico@cryptonector.com>
To: Robbie Harwood <rharwood@redhat.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v18] GSSAPI encryption support
Message-ID: <20180611230026.GC23356@localhost>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com>
 <jlg1se287n3.fsf@redhat.com>
 <jlg602phyn5.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <jlg602phyn5.fsf@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On Mon, Jun 11, 2018 at 04:11:10PM -0400, Robbie Harwood wrote:
> Nico was kind enough to provide me with some code review.  This should
> those concerns (clarify short-read behavior and fixing error checking on
> GSS functions).

Besides the bug you fixed and which I told you about off-list (on IRC,
specifically), I only have some commentary that does not need any
action:

 - support for non-Kerberos/default GSS mechanisms

   This might require new values for gssmode: prefer-<mechanism-name>
   and require-<mechanism-name>.  One could always use SPNEGO if there
   are multiple mechanisms to choose from.  And indeed, you could just
   use SPNEGO if the user has credentials for multiple mechanism.

   (Because GSS has no standard mechanism _names_, this means making
   some up.  This is one obnoxious shortcoming of the GSS-API...)


 - when the SCRAM channel binding work is done, it might be good to add
   an option for TLS + GSS w/ channel binding to TLS and no gss wrap
   tokens


Nico
--