Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fdRjZ-0002KS-J2 for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Jul 2018 02:53:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fdRjX-0004oJ-Kg for pgsql-hackers@arkaria.postgresql.org; Thu, 12 Jul 2018 02:53:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fdRjW-0004oC-2U for pgsql-hackers@lists.postgresql.org; Thu, 12 Jul 2018 02:53:31 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fdRjN-0000Ws-IQ for pgsql-hackers@postgresql.org; Thu, 12 Jul 2018 02:53:29 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id F073618A; Wed, 11 Jul 2018 22:53:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 11 Jul 2018 22:53:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=zpWHm8ayVkTHY6hhsV6WkLsWw4eBvJJ5OLmu4Sr4/2w=; b=pkRjEMNd irzn4ip0CSEq7P3ucm9lKxgQn6BvOMWk3kiw15gLsUZj3CfVtpSqp8gwrm9MMtq1 2MQaJb3cXa5X18VwcFNecW54b9cd4W7GcE67dYJjvJCgSlm5IVVN21gPIBOkV5gM DOaKyZ+Jm1Wf9pM4kZuBFo1/P7yVSKUPdfmfM+Qq/0hoxfPa+oToUom2kTT1T1+t MjyU6EGr2/SF55Wqjwy8utKr0VcMc4mx/+u8aFvXPdzak//UgMR0J05jTSGY04Kx qIO40wFvx/gC3IVxhEo/EnJjD5Di/6JCxl23Aliv7q7ytDmIi2VchkO4me/3v22H XAk8S8nlAYOM6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=zpWHm8ayVkTHY6hhsV6WkLsWw4eBv JJ5OLmu4Sr4/2w=; b=QYr8WkXRUGMNoeOjEGTaQx12vWkQzCwdjmxxe6wQnmM9C 0ViWr3TuS9y8Fhzw1mLDmSVISPveysanJz0dQ3CYJpRdrPysAnCFj9XH0sTR93c9 h8f0WETUFPkG0DKC3krOPH8H7FklP/wC0sgi1jMuyoWHbY6E9kdqFr+8owJ0TF+o ExLDOIgfxybOB0KHyCKwqdXNtK0iJfxN2Mhg55iCUHWyuCseZoWutkL/oylzjDhp jf5xq0OpLtSTGfCXvvZ2rvqMYkDFofw21PFlBJCOyoohOguM4slBAtoQ51/tpHWv 3FhOjSZcXbIijDdn1OqKs5ek0JCz203OUZ3AS/LMg== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id E5081E435C; Wed, 11 Jul 2018 22:53:16 -0400 (EDT) Date: Thu, 12 Jul 2018 11:53:08 +0900 From: Michael Paquier To: Alvaro Herrera Cc: Pg Hackers Subject: Re: TRUNCATE tables referenced by FKs on partitioned tables Message-ID: <20180712025308.GA7352@paquier.xyz> References: <20180711071647.GC14301@paquier.xyz> <20180711225916.domrlbkmukhrg6jg@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0" Content-Disposition: inline In-Reply-To: <20180711225916.domrlbkmukhrg6jg@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --6TrnltStXW4iwmi0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 11, 2018 at 06:59:16PM -0400, Alvaro Herrera wrote: > Anyway, this patch seems to fix it, and adds what I think is appropriate > test coverage. This looks good to me. I am noticing that the documentation of TRUNCATE does not mention that when running the command on a partitioned table then it automatically gets to the children even if CASCADE is not used and each child partition is not listed. What is the filler column added in truncpart used for? -- Michael --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAltGwpQACgkQnvQgOdby QH0xkg/9EfFXSveHYOVLoC5dRFFZ91Zo9XaZq+4uNjzO4TESHbvBdHvh5VRWu/vi sI+P767cLY04z42Fry9/lzg50Nx4mxbeGSOvxVNf8SjEGBuYBGptzbZia/j8/V6e 9I8fvKSbkLzqhRmvKVDoYghrkuLsDf1XM3q/UB4gcSYNmJK8InL/yqXCCrZSQhtE jlPA6c5mKPNfrUaPfkTQNSMkewk8B3DHZOI3yfc5EAUa645oDWltm8JKTk6xxI3S +Et/RgFF9reA2kvcrN55TJFsTLkjw8X4s2j5VGOSf4nt5ecZAZf6APNlRgKqnULl LHNp5RO2QX70oFOVXoM9lCNQCbKi0HNKMZGGUGTLKLF7Q7fFcPrieE5Q2Z6iYxHB 3jO7BVHgxFt4yi/5x+ZoZMF4wRu+YXfRxcxrJyk8KPFDcc44oDh4jgqX5tfy2QbX WvZspR5XQN7YyLukQJrHnsJGUnf/XZOxtG/yjhW3NxDbhyTW+EYHj6ESNHnB3YFJ aVcni1emV59xJSPnWuX5JtbPV1v3f+jh0nNx3tPilhq3PYal6j4nu3GZx4PO39ON FMxgmFBDJbuJ0SmK9kIIoBhNcrUJujrCYxAwAIaiWcVpjEwTYjwLOKowtEliVxNS yLlaSW9xF3Dcv63Ks7kM3x4mPiW5Kccm2hLBNtWpxQ2Pkdw998c= =jRQm -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0--