Date: Tue, 17 Jul 2018 15:58:34 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
	Bruce Momjian <bruce@momjian.us>
Subject: Re: file cloning in pg_upgrade and CREATE DATABASE
Message-ID: <20180717065833.GG3388@paquier.xyz>
References: <bc9ca382-b98d-0446-f699-8c5de2307ca7@2ndquadrant.com>
 <20180319070636.GA4633@paquier.xyz>
 <20180319071415.GB4633@paquier.xyz>
 <20180320025849.GB4963@paquier.xyz>
 <678999c6-0967-d22a-e7d1-2a3aff83a77b@2ndquadrant.com>
 <20180323171650.GI1302@momjian.us>
 <4a62b089-ee93-50ee-f3f7-43c67b4c8ea4@2ndquadrant.com>
 <0241eae2-2f31-3667-200d-ae0e2293f692@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="6BvahUXLYAruDZOj"
Content-Disposition: inline
In-Reply-To: <0241eae2-2f31-3667-200d-ae0e2293f692@2ndquadrant.com>
Precedence: bulk


--6BvahUXLYAruDZOj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 06, 2018 at 11:58:14AM -0400, Peter Eisentraut wrote:
> <para>
>  The setting <literal>always</literal> requires the use of relinks.  If
>  they are not supported, the <application>pg_upgrade</application> run
>  will abort.  Use this in production to limit the upgrade run time.
>  The setting <literal>auto</literal> uses reflinks when available,
>  otherwise it falls back to a normal copy.  This is the default.  The
>  setting <literal>never</literal> prevents use of reflinks and always
>  uses a normal copy.  This can be useful to ensure that the upgraded
>  cluster has its disk space fully allocated and not shared with the old
>  cluster.
> </para>

Hm...  I am wondering if we actually want the "auto" mode where we make
the option smarter automatically.  I am afraid of users trying to use it
and being surprised that there is no gain while they expected some.  I
would rather switch that to an on/off switch, which defaults to "off",
or simply what is available now.  huge_pages=try was a bad idea as the
result is not deterministic, so I would not have more of that...

Putting CloneFile and check_reflink in a location that other frontend
binaries could use would be nice, like pg_rewind.
--
Michael

--6BvahUXLYAruDZOj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAltNk5kACgkQnvQgOdby
QH39jxAAheRkMo61wFq0P36b1cBnZVl4Cu0F22G+BgLHGpKkU/R/+EonZ0HS7Znp
sh5IDMhnCkO6Lwx6Q6l0YpBjJyMMMrNBFCWVBINymqLgAu3U9qfNDz1kvoPDs19k
fHfjMqjICF9BfYJOGmehiYcEIT0T9xpiNIvZYIoleriI/NoK1nPuAi99bwMuRpPE
XRCWGlODzOUdGgiUjuE10KRgEKlyZXOyZdPGxH14nqEz77AbxwrYMpNKa13KgLIj
2YcJ+dfjhg0JsEK+40JIHK8Tq1FejY6E6bB1R7sMrzLkOge4qk47YhZzeHxsfyiI
+FuBehbl78TPSvwao5VkFr+mUgw3UZxxflnr6G+3EwgCaD62mKef1cuh419IZqhM
TXIrXMHMdcsirFmZw5Sq1VVnwzaqF55E5poZ3ryN8CnxlIlDUDJ0z1oEYlsoABjL
A0zstwDqr1H2cqLErYxDStLcmA2S2LrLvpHDbz/HdX+8mPA8ERrMIApqbC3WoxrA
GeANyvkmRWrxDNkej/OEXKLpyOt5vfnWdnsYVsWmftdwyRcfLXe0go/pQss64ACQ
LC6SjS8tdeEt0oZjI6BSxWGdribm8rY/KhY/VeLLv2tSpFK2oef2v1OtWz34iIlH
h9G//AvoWTW7RWDsBT7aHu98q2k08wSuAjl3ryWLXMrYZ/kASUQ=
=gu8z
-----END PGP SIGNATURE-----

--6BvahUXLYAruDZOj--