Date: Wed, 18 Jul 2018 15:22:02 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Robert Haas <robertmhaas@gmail.com>,
	Ashutosh Bapat <ashutosh.bapat@gmail.com>
Subject: Re: print_path is missing GatherMerge and CustomScan support
Message-ID: <20180718062202.GC8565@paquier.xyz>
References: 
 <CAD21AoBQMLoc=ohH-oocuAPsELrmk8_EsRJjOyR8FQLZkbE0wA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/aVve/J9H4Wl5yVO"
Content-Disposition: inline
In-Reply-To: 
 <CAD21AoBQMLoc=ohH-oocuAPsELrmk8_EsRJjOyR8FQLZkbE0wA@mail.gmail.com>
Precedence: bulk


--/aVve/J9H4Wl5yVO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 18, 2018 at 02:35:23PM +0900, Masahiko Sawada wrote:
> Hi,
>=20
> While debugging planner I realized that print_path() function is not
> aware of both GatherMerge path and CustomScan path. Attached small
> patch fixes it.

Good catch.  Those should be backpatched.  While I am looking at this
stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
T_MergeAppend and not T_MergeAppendPath.

--- a/src/backend/optimizer/util/pathnode.c
+++ b/src/backend/optimizer/util/pathnode.c
@@ -3817,7 +3817,7 @@ do { \
            }
            break;

-       case T_MergeAppend:
+       case T_MergeAppendPath:
            {
                 MergeAppendPath *mapath

This is new as of f49842d1 in v11.  Robert, Ashutosh, am I missing
something?
--
Michael

--/aVve/J9H4Wl5yVO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAltO3IoACgkQnvQgOdby
QH1a2BAAgJmtO/HrbKnGwcq+pjznryrkqVUNtLO5VOdT7XTZkUOFv6RVK6n0CM/W
cUubUCSPgYvJZKx6YK1ePEZGBEu70AdmDIthpMwOOciW2SZ0Asn7G76z7DvZ2bmb
ejAqQrDFOWJ8TN32lDn1m4CLnBeyk/V2tPCc9dv0l3aV3y9jSXGXc5gX/EqH4XbI
bjm6JAOChnx3hLUHT8mteVMeswd7QV7bYvhG7/p3LCAX24btJi7AtPk8n9kbyXvA
i5hQWsbHSJ4XIM871rTnzvHeAioB1D9Ufym3OCwswHyzoQebyW8ClStOURk7DlTf
9g62k7KC8zUYxbgo+oN066pOsmycS2o+OWnLy0/y2QjKIDPp3Wh7KhDekiky9nka
ilRqRzeoYYx1S7+MOGZoU7TmjR26Ua9R/49TA9kHV4leO69m3cdyG8jMsE01BjXg
MdcjET89Hy2ukvsqp1VPJCOg8cnRc69Amyx/uhhcXhOHIJh/UX10Ba/+GOrmytPj
V+qaxXf7DdFKRy6RoUXQxRQqTtbLf1ZV7dcnMxynbT8S6t+t5E6NKf2EtBincxQC
Ag/Uc7v8xbfDiBhri8zZWkbfTOLQQMAiEZCm/f/8+2wy6tZpwvKb//boPcHtUekk
qYWVxK+4rVPfFq8FaGg66YFDaCuUcmrO+sA4almRdneFfwfkDJA=
=M3Fk
-----END PGP SIGNATURE-----

--/aVve/J9H4Wl5yVO--