Date: Wed, 18 Jul 2018 15:55:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Robert Haas <robertmhaas@gmail.com>
Subject: Re: print_path is missing GatherMerge and CustomScan support
Message-ID: <20180718065524.GE8565@paquier.xyz>
References: 
 <CAD21AoBQMLoc=ohH-oocuAPsELrmk8_EsRJjOyR8FQLZkbE0wA@mail.gmail.com>
 <20180718062202.GC8565@paquier.xyz>
 <CAFjFpReLXu9qa2a-bt9-yDiT6UZn1+nh_1dEVkJuCXu6y838Aw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Bg2esWel0ueIH/G/"
Content-Disposition: inline
In-Reply-To: 
 <CAFjFpReLXu9qa2a-bt9-yDiT6UZn1+nh_1dEVkJuCXu6y838Aw@mail.gmail.com>
Precedence: bulk


--Bg2esWel0ueIH/G/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 18, 2018 at 12:15:25PM +0530, Ashutosh Bapat wrote:
> On Wed, Jul 18, 2018 at 11:52 AM, Michael Paquier <michael@paquier.xyz> w=
rote:
>> On Wed, Jul 18, 2018 at 02:35:23PM +0900, Masahiko Sawada wrote:
>>> Hi,
>>>
>>> While debugging planner I realized that print_path() function is not
>>> aware of both GatherMerge path and CustomScan path. Attached small
>>> patch fixes it.
>>
>> Good catch.  Those should be backpatched.  While I am looking at this
>> stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses
>> T_MergeAppend and not T_MergeAppendPath.
>>
>> This is new as of f49842d1 in v11.
>=20
> Yes that's right. Thanks for taking care of it.

Thanks for the confirmation.  Robert, do you want to take care of this
issue or should I?

>> Robert, Ashutosh, am I missing
>> something?
>=20
> You used my personal email id by mistake, I think. I have removed it
> and added by EDB email address.

My sincere apologies.  I have not been careful.
--
Michael

--Bg2esWel0ueIH/G/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAltO5FwACgkQnvQgOdby
QH3qxQ/+KSBlipX6zH2rtyKhu3Sef1TR72CJTaGdoDgwwdyjR854J1ACPg+0HjS1
k9M58DuzkG3ld22LxzM5Q4o2S4M41QcJGoV4gBXKR6yKOwhaZMd5AQkJRycjyrW2
BE8172GQ4T2TFSn7/SkM77JoH0j7755dbLBE+3yRdL4p1sniW0/JfONdTs8S+EMn
UhbQtdqBkwWlj5sNwlZ0ySLZ2MH95SjKgU8RtiRZmLz6dyhn19U95g2btr3ZD0rd
dekq/H0ylT9hD9am7vIQw8+8OmmApC+bJQBVFo1uMv6ZtFW6pnOC9XESHqPXwZ5p
lE3rul4n8V7MfLw0jWoQBiQZMGYAuAHqF0KLfqzZOXN4PKNSGy5iknhQ/2ouna5G
U7nsSziHXeVahKpFwnHiuGJ12wcMyzKjbN0LiBCCLLSQVn1IjzFYpScl7SwrqBIn
vF/h8t5UeJIbquGOETwlWMftFRu3E325V+a/MnsUazVjwPyBniUlMdvEG0HEIOYY
uhduUjz8B3J2hCcKxpisDQF+Vdpn/RsBVmXWi4bRHoJYDdafgH0ZfooGlB1sOtT2
zTXR+s4Jlpgb5Pe/iJKonRSKXch+PYeRd49qYAvp/4/rQPtCwslylE0qY1Sp1nYX
Z9KeCho23BQIKSeACYOT1nPCF9B9GDezmRLd8gVzY2/v4OrexGE=
=kNXi
-----END PGP SIGNATURE-----

--Bg2esWel0ueIH/G/--