Date: Thu, 19 Jul 2018 15:26:50 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Robert Haas <robertmhaas@gmail.com>
Subject: Re: print_path is missing GatherMerge and CustomScan support
Message-ID: <20180719062650.GL3411@paquier.xyz>
References: 
 <CAD21AoBQMLoc=ohH-oocuAPsELrmk8_EsRJjOyR8FQLZkbE0wA@mail.gmail.com>
 <20180718062202.GC8565@paquier.xyz>
 <CAFjFpReLXu9qa2a-bt9-yDiT6UZn1+nh_1dEVkJuCXu6y838Aw@mail.gmail.com>
 <20180719000722.GA3411@paquier.xyz>
 <CAFjFpRf3yGODbCyrR4zfcbWbQOv=DqtfvwZ=qUh2Wfa3ODe-TA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HVCoas+krw6dou6l"
Content-Disposition: inline
In-Reply-To: 
 <CAFjFpRf3yGODbCyrR4zfcbWbQOv=DqtfvwZ=qUh2Wfa3ODe-TA@mail.gmail.com>
Precedence: bulk


--HVCoas+krw6dou6l
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 19, 2018 at 10:41:10AM +0530, Ashutosh Bapat wrote:
> I had extensive testcases in my original patch-set to exercise that
> code but 1. that testset was too extensive; even today
> partition_join.sql is a separate testcase and it's quite large. 2.
> that function returns NULL rather than throwing an error, if it can
> not produce a parameterized path. So, unless we check whether each of
> those paths get created no test is useful and that can only be done
> through an EXPLAIN OUTPUT which means that the testcase becomes
> fragile. I fine if we want to add more tests just to cover the code if
> those are not as fragile and do not blow up partition_join too much.

Did those really check the reparameterization of a MergeAppendPath for a
child of the parent?  I'd be surprised if this one was stressed as there
was no match in the list.
--
Michael

--HVCoas+krw6dou6l
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAltQLyoACgkQnvQgOdby
QH0VjQ//fD7ahucQdV/pRbjg7vT+Uir1s0O3jCEmJKZE/BxEa7NvfdbsPlOpUJjH
HqiduLy1EtE32mAvnp7C6TtKQ/xXu8DKuaydC9KlCMxE7MB1Bqi5HlocbmE9Q0PJ
Ka44OViL+fMbtrkW7L65HzPSRRtaOy+7/ErsgmGcAj6UvTTxfP9gTBoXtnwGW633
7jlS93BncWM9WGYg3DrkNuC5x2e6f0NzCcCa8Ztl84jFYVs0WJVq0766jWB6ORyb
ysb0DqQwvzwnwxYbH2fVcWkDBeGQuZLBoNMKSK1nr63If2m5lH5p4BwtFr84GXwa
mKw+be6886m9J9TMKU+qTbUAlr7p6Bu5gDta32KGWWs4XEnAMVGzcChyB+WlCrO7
8HwWS8I2Qj+sK2Jul/vte4tURnGVyApJ1kJcPIL4UAGtgdE6uqzdvaCId9l2eKMv
LMyH2+GX9zaj240gJasup0pBz6ldZT8JZGFbktFAh7pyUYgHS4JlCOY/n8E/Ou6C
lmPiAt/mA9JMBY7SqRAU/3K2+wZxWeJJZ823o/iWz/HyqozcJgkBt9cWnOwHsHCu
16Jv3SxgACiPUFFeqtq7sKGaE5ZbQXwKqFuhazAZ/SOBhsFlkBAhLvY19R/Fn4uy
Vpw3k+ObRA5tMTBK2QdUa/HU4Hsu7ZytheourFN10X0Y9ICKzwQ=
=geHb
-----END PGP SIGNATURE-----

--HVCoas+krw6dou6l--