Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhSdT-0002HV-U9 for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jul 2018 04:39:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fhSdR-0004i0-MQ for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jul 2018 04:39:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fhSdR-0004ht-AF for pgsql-hackers@lists.postgresql.org; Mon, 23 Jul 2018 04:39:49 +0000 Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fhSdN-00061k-BU for pgsql-hackers@postgresql.org; Mon, 23 Jul 2018 04:39:48 +0000 Received: by mail-qk0-x242.google.com with SMTP id z74-v6so9416026qkb.10 for ; Sun, 22 Jul 2018 21:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=jq+9XuneCu9Nqafx9x0RBYD2f6XWHevIGAUOFM50fkg=; b=Md7/nQ3bE0+Cb7dtbQjFnVybec01uER2S4ACFrFmpMWDRpiVei0DPCDj/kTQKdp1cf ODCdYXO4cQOVqyE89owQvvGn2bZiG7hmYOh9CWcLJzLvzg3X80Tpyjvj+Tq/Zl36tMAH 4lSQsSt85LwFPHyOH6o0BwRvy/STaoQPzCRX/6tBDVR3TzMo6Ye2tRz0+sgv6ytReCip cJilDPChfpLs6PKioQQd5Xliev+6wJiUI3wGA2XOCqE7GfdVV0fooRvGknDNWmIcmxlK TExEJLLB0B1z2XHrxNYlPwrz7yBA0o09ClB+3uippS+K3qZH8Vj4KjZ1Tl2y7bAZcetD G1PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jq+9XuneCu9Nqafx9x0RBYD2f6XWHevIGAUOFM50fkg=; b=NKbB0vZEn4BloxfzD/BxFoPTLumhO9XR4xhDsniOshW7aX+/1begZM5LWQJgH4wvJK YxyF5td/bMVMNA7rbWIqa0jI2oetTUCY0HbKsK4hfY3ZfIF1JbxnJPFuhsEhHGFRqkrl ZZtmUdD1z0NvocT2pdAxZevLAn2erQgouLThSRyLq3RjhCZj7gCBk64WMlJ2TbjATskI VsBYqi47YcmddbxiEzqg4UcXt4OSx2DUJ3CfTQsF3ALIsF+eyIOZmk/23zQIACTWvPRH cPd+eTLvqv9hPk/WvHlmwNoIAnX7rgx9HO/AToNZG1J/SHSVbQT4df+6bwtRGLwezqAW /qzQ== X-Gm-Message-State: AOUpUlHqZkqMf6YUQJdrWDlUDiUyWDfyw/a6WHD4hj4zx7xusJPXNO6z HJ7Ihu0MacpaVcxAVJMFTKc5CA== X-Google-Smtp-Source: AAOMgpdgeU3V/yt/ZjTgKawEjv8v3smyLjJIhA0ZaCShREIshzeZnf3cDQlWeVa72DSoAVEsVf70dQ== X-Received: by 2002:a37:264b:: with SMTP id y72-v6mr9476656qkg.340.1532320783206; Sun, 22 Jul 2018 21:39:43 -0700 (PDT) Received: from alvin.alvh.no-ip.org ([179.56.48.71]) by smtp.gmail.com with ESMTPSA id k8-v6sm5689379qti.4.2018.07.22.21.39.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Jul 2018 21:39:42 -0700 (PDT) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id E17A58A4; Mon, 23 Jul 2018 00:39:40 -0400 (-04) Date: Mon, 23 Jul 2018 00:39:40 -0400 From: Alvaro Herrera To: Tom Lane Cc: Michael Paquier , Stephen Frost , Andrew Gierth , Peter Eisentraut , pgsql-hackers@postgresql.org, Andres Freund Subject: Re: Should contrib modules install .h files? Message-ID: <20180723043940.dc4s2qv6lefllg2d@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <21149.1532319353@sss.pgh.pa.us> User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2018-Jul-23, Tom Lane wrote: > Michael Paquier writes: > > On Sun, Jul 22, 2018 at 09:42:08PM -0400, Stephen Frost wrote: > >> So, +1 from me for having a directory for each extension. > > > So, like Stephen, that's a +1 from me. > > Same here. One-file-per-extension is too strongly biased to tiny > extensions (like most of our contrib examples). > > I don't have a real strong opinion on whether it's too late to > push this into v11. I do not think it'd break anything other than > packagers' lists of files to be installed ... but it does seem > like a new feature, and we're past feature freeze. Frankly, I'd rather make things as easy as possible for third-party extension writers. I'd go as far as backpatching further (considering transforms were introduced in 9.5) but I hesitate on that, because of the packagers argument. pg11 seems fair game to me, though. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services